Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 60s timeout for read_thread, revert read limits #174

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

zdohnal
Copy link
Member

@zdohnal zdohnal commented Apr 13, 2021

See #160 . It contains fixes for #160 and #72 .

Some older models malfunction if timeout is too short.
This commit reverts the change introduced by 2.2.12 [1] - its
implementation caused a regression with Lexmark filters.

[1]
apple/cups@35e927f
@zdohnal zdohnal changed the title Usb read timeout final Use 60s timeout for read_thread, revert read limits Apr 13, 2021
@michaelrsweet michaelrsweet self-assigned this Apr 13, 2021
@michaelrsweet michaelrsweet added bug Something isn't working priority-medium labels Apr 13, 2021
@michaelrsweet michaelrsweet added this to the v2.4.0 milestone Apr 13, 2021
@michaelrsweet michaelrsweet merged commit 43edb9d into OpenPrinting:master Apr 13, 2021
@zdohnal zdohnal deleted the usb_read_timeout_final branch May 13, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USB communication with device fails from CUPS 2.2.12 due to CUPS code change (Issue #5583).
2 participants