Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default wanted-by target to printer.target #316

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fix default wanted-by target to printer.target #316

merged 1 commit into from
Jan 3, 2022

Conversation

swsnr
Copy link
Contributor

@swsnr swsnr commented Jan 1, 2022

There is no printers.target in systemd, only printer.target (see man bootup).

This regression was introduced in #143

There is no printers.target in systemd, only printer.target (see man bootup).

This regression was introduced in #143
@zdohnal zdohnal self-requested a review January 3, 2022 13:25
@zdohnal zdohnal self-assigned this Jan 3, 2022
@zdohnal zdohnal added bug Something isn't working priority-medium labels Jan 3, 2022
@zdohnal zdohnal added this to the v2.4.1 milestone Jan 3, 2022
@zdohnal
Copy link
Member

zdohnal commented Jan 3, 2022

Hi @lunaryorn ,

thanks for the check and I'm sorry for the regression - I've overlooked the typo when I wrote the PR :( .

Copy link
Member

@zdohnal zdohnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@zdohnal zdohnal merged commit 6ef3946 into OpenPrinting:master Jan 3, 2022
@swsnr swsnr deleted the patch-1 branch January 3, 2022 18:15
@swsnr
Copy link
Contributor Author

swsnr commented Jan 3, 2022

No worries, thanks for merging 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants