New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtest 20180102 - Actions/min doesn't count move (and other) commands #14671

Closed
Arular101 opened this Issue Jan 5, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@Arular101
Contributor

Arular101 commented Jan 5, 2018

Tested by ordering the MCV around. Watching the replay afterwards the actions/min stayed at 0.
Attack command is also not counted. However, clicking on structures/units to build in the build-tab is counted.

Thanks FiveAces for noticing it.

@pchote pchote added this to the Next release milestone Jan 6, 2018

@abcdefg30 abcdefg30 added the Bug label Jan 8, 2018

@jongleur1983

This comment has been minimized.

Show comment
Hide comment
@jongleur1983

jongleur1983 Jan 8, 2018

Contributor

PlayerStatistics.ResolveOrder() is never called, thus not counting orders.
The PlayerStatistics trait is indeed created and it's ITick.Tick() is called in the game loop.
This updates the statistics (Actions/min and so on), but based on the wrong numbers (number of orders stays 0 due to the missing ResolveOrder)

I have no idea what's the root cause of that, so I can't solve the issue, but perhaps this helps someone else.

Contributor

jongleur1983 commented Jan 8, 2018

PlayerStatistics.ResolveOrder() is never called, thus not counting orders.
The PlayerStatistics trait is indeed created and it's ITick.Tick() is called in the game loop.
This updates the statistics (Actions/min and so on), but based on the wrong numbers (number of orders stays 0 due to the missing ResolveOrder)

I have no idea what's the root cause of that, so I can't solve the issue, but perhaps this helps someone else.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jan 24, 2018

Member

The APM calculation has always been bogus in OpenRA. If nobody can volunteer a fix then IMO this should be removed from the observer interface instead of delaying the release further.

Member

pchote commented Jan 24, 2018

The APM calculation has always been bogus in OpenRA. If nobody can volunteer a fix then IMO this should be removed from the observer interface instead of delaying the release further.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jan 25, 2018

Member

This was introduced by #13876. The APM code relied on that CreateGroup order to know when the player issued a command.

Member

pchote commented Jan 25, 2018

This was introduced by #13876. The APM code relied on that CreateGroup order to know when the player issued a command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment