Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rally points do not work on construction yards (and cause harvs to get blocked) #15995

Closed
ubitux opened this issue Jan 4, 2019 · 8 comments · Fixed by #17021
Closed

Rally points do not work on construction yards (and cause harvs to get blocked) #15995

ubitux opened this issue Jan 4, 2019 · 8 comments · Fixed by #17021

Comments

@ubitux
Copy link
Contributor

ubitux commented Jan 4, 2019

Contrary to other buildings, construction yards do not seem to be target-able, leading to the following issue:

cyard-rp

This is particularly problematic when the rally point is set to the first expansion, trickling units supposed to go there to defend it don't, army stays out of position.

This does not happen with other buildings:

pp-rp

But is OTOH behaving the same as with an invalid rally point (this one is probably fine):

invalid-rp

The issue is present in both release-20181215 and bleed @ a77d2f1

@MustaphaTR
Copy link
Member

Construction Yard is 4x3, if you don't count the bib it is 3x3 which has a cell that is complately covered by other impassable cells probably why the issue triggers with CY but not APP

@ubitux
Copy link
Contributor Author

ubitux commented Jan 4, 2019

That's indeed probably the case: a rally point on the cells other than the center one of the 3x3 do work. You can also reproduce the issue while stacking a bunch of airports, for example like this:

building-stack-rp

Note that an explicit order at that same location will "work" (the units will find their place around the specified area).

@MustaphaTR
Copy link
Member

Difference may lie between (Force)Move and AttackMove orders, since rally points queue an AttackMove order.

@ubitux
Copy link
Contributor Author

ubitux commented Jan 4, 2019

A manual attack move is adjusted to an alternative point so a manual order gets honored. I understand that adjusting the rally point itself might be complicated, especially if a building is build after the point is set.

@ubitux
Copy link
Contributor Author

ubitux commented Jan 4, 2019

Note that a side effect of this bug is causing some harv to get stuck if you're building a structure on the default rally point of the war factory. Huge penalty in early game.

stuck-harv

In the above screenshot, the harv in front of the war factory doesn't move, it's just stuck.

@ubitux ubitux changed the title Rally points do not work on construction yards Rally points do not work on construction yards (and cause harvs to block) Jan 5, 2019
@ubitux ubitux changed the title Rally points do not work on construction yards (and cause harvs to block) Rally points do not work on construction yards (and cause harvs to get blocked) Jan 5, 2019
@ubitux
Copy link
Contributor Author

ubitux commented Feb 20, 2019

Yet another situation where the rally point "bugging" out:

rally-wf

@ubitux
Copy link
Contributor Author

ubitux commented Mar 24, 2019

Here is a gif to illustrate the difference between move and a-move:

move-vs-amove

Since a rally-point is a non-adjusted a-move, this might be the cause of all of this.

@abmyii
Copy link
Contributor

abmyii commented Dec 10, 2019

Since, the issue has got worse - any building will now block the units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants