Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can deploy onto other units #16826

Closed
PunkPun opened this issue Jul 22, 2019 · 3 comments · Fixed by #16852
Closed

You can deploy onto other units #16826

PunkPun opened this issue Jul 22, 2019 · 3 comments · Fixed by #16852
Assignees

Comments

@PunkPun
Copy link
Member

PunkPun commented Jul 22, 2019

In TS I gave the Subterranean APC ability to transport vehicles on bleed
Then moved tick tank into it and double clicked the deploy button

Bug

@PunkPun
Copy link
Member Author

PunkPun commented Jul 23, 2019

I just realised that this bug can also be reproduced in RA with MAD tanks and Transports. Tho it doesn't show the glitchy undeploy from the gif above

@pchote
Copy link
Member

pchote commented Jul 23, 2019

The issue here isn't related to transports and isn't specific to TS.

GrantConditionOnDeploy has regressed to allow units to allow these units to deploy when they are off-grid. This can be reproduced with a normal move order and the /terrainoverlay mode to compare vs the standard cell grid.

@tovl
Copy link
Contributor

tovl commented Jul 27, 2019

Currently, DeployForGrantedCondition doesn't check if the deploy location is valid at all.

To fix this, DeployForGrantedCondition should call deploy.CanDeploy() in OnFirstRun.

It turns out this actually has nothing to do with GrantConditionOnDeploy (not surprising considering MAD tanks don't actually use GrantConditionOnDeploy). You can see a similar thing happening when you double click a normal move order while entering the transport: the unit will instantly teleport to an adjacent cell. The fault is with MoveIntoWorld, which should not be interruptible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants