Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrantConditionOnDeploy: cannot grant timed condition #17331

Closed
MlemandPurrs opened this issue Nov 15, 2019 · 5 comments
Closed

GrantConditionOnDeploy: cannot grant timed condition #17331

MlemandPurrs opened this issue Nov 15, 2019 · 5 comments
Labels
Limitation

Comments

@MlemandPurrs
Copy link

This makes it impossible to say, have an Mammoth Tank variant that has an portable Iron curtain device on it.
GrantExternalConditionPower: can specify an Duration: for the condition it puts on the affected units, so GrantConditionOnDeploy: probably should able to do that too.
@pchote
Copy link
Member

pchote commented Nov 15, 2019

Related: #15688.

@GraionDilach
Copy link
Contributor

GraionDilach commented Nov 15, 2019 •
edited

AS have an implementation for years. Including conditional support.

https://github.com/AttacqueSuperior/Engine/blob/master/OpenRA.Mods.AS/Traits/Conditions/GrantTimedConditionOnDeploy.cs

@MlemandPurrs
Copy link
Author

Ive taken the GrantTimedConditionOnDeploy from CA mod seems to be working seamlessly.

@PunkPun
Copy link
Member

PunkPun commented Jul 7, 2022

Related #12542

@abcdefg30
Copy link
Member

Should be closed by #20824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Limitation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pchote @GraionDilach @abcdefg30 @PunkPun @MlemandPurrs