Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport movement stutter in isometric mods #17336

Open
ghost opened this issue Nov 15, 2019 · 3 comments
Open

Viewport movement stutter in isometric mods #17336

ghost opened this issue Nov 15, 2019 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 15, 2019

Most noticeable in the radar widget when moving the viewport. I think this is not limited to the box displayed in the radar widget but that the stutter is actually there when you move the viewport, at least I think that I see it with keyboard scrolling. Side-note: It is also noticeable when cherry-picking a027222 on top of #17308.

See the animation below for the comparsion of RA vs TS:

RA

no-stutter

TS
stutter

Edit:
Also present on 5d786f4, so it's not a regression from the render-rework.

@GraionDilach
Copy link
Contributor

Yes, because this has nothing to do with rendering.

The radar box is drawn around the center cell visible. The thing here is that at isometric worlds the axis don't align with the implicated scroll axis, and you constantly switch between map rows/coloumns during scrolling, which the radar box just follows.

Example movement during a left-right scrolling.
image

@tovl
Copy link
Contributor

tovl commented Nov 19, 2019

It seems the solution then would be to base the radar box around the center WPos instead of the CPos.

@GraionDilach
Copy link
Contributor

Another suggestion which came to my mind is to limit the scrolling to jump two rows/coloumns with each step in a fashion like below (where only Xes are the cells which can be viewport centers). Sounds like simple workaround to me and I don't think it would be much noticable anyway.

XOXOXO
OOOOOO
XOXOXO
OOOOOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants