Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvester forgets to finish queued ore #17499

Open
PunkPun opened this issue Dec 23, 2019 · 7 comments
Open

Harvester forgets to finish queued ore #17499

PunkPun opened this issue Dec 23, 2019 · 7 comments
Assignees

Comments

@PunkPun
Copy link
Member

PunkPun commented Dec 23, 2019

When you queue a few harvest orders and the ore truck returns back to refinery on its own it forgets to finish up the ore it had started harvesting before getting full and moves onto next orders

Harvester

@pchote
Copy link
Member

pchote commented Dec 23, 2019

We may want to consider this for the hotfix if the fix doesn't end up being too complicated.

@pchote pchote added this to the Next Release milestone Dec 23, 2019
@ghost
Copy link

ghost commented Dec 25, 2019

This behavior seems to be more efficient than to continue harvesting a desaturated cell (2 vs. 3 harvesting runs).

@PunkPun
Copy link
Member Author

PunkPun commented Dec 25, 2019

It depends on the situation

@ghost
Copy link

ghost commented Dec 26, 2019

Example

@ghost
Copy link

ghost commented Dec 26, 2019

Ah, nvm. Don't think it's worth discussing it

@pchote
Copy link
Member

pchote commented Dec 28, 2019

The issue here is that FindAndDeliverResources never explicitly checks the state of the targeted cells. It assumes that it is done with the current cell as soon as HarvestResource is complete - this assumption fails when the harvester fills up and HarvestResource returns early.

I don't see a simple fix, so removing from the milestone.

@pchote pchote removed this from the Next Release milestone Dec 28, 2019
@tovl
Copy link
Contributor

tovl commented Dec 28, 2019

It assumes that it is done with the current cell as soon as HarvestResource is complete

It actually assumes nothing at all. The problem is that the pathfinder cannot return just the tile from which the search started. The path will be empty and therefore it is impossible for the search to yield the searchFromLoc itself. We already have a workaround for that when there is an explicit harvest order and we use a similar workaround to allow the harvester to find the cell it is currently in (which is used as the alternative start point). We can add the same workaround for lastHarvestedCell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants