Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defination and Purpose of 'GlobalButtonOrderGenerator' #17768

Open
dnqbob opened this issue Mar 6, 2020 · 1 comment
Open

Defination and Purpose of 'GlobalButtonOrderGenerator' #17768

dnqbob opened this issue Mar 6, 2020 · 1 comment

Comments

@dnqbob
Copy link
Contributor

dnqbob commented Mar 6, 2020

Orignal GlobalButtonOrderGenerator is very strict and only enough for classical C&C global order button and even only inherited by two classes (powedown and sell) at present, because repair function is more complicated after it can repair vehicle which is out of the box of GlobalButtonOrderGenerator.

I feel bad about it, so what is Global Order stand for in OpenRA?

IMO, Global Order should be defined as "let actors perform regular action while ignoring current selection collection set", a very special design can be seen in most C&Cs, and all designs that are similar to this defination or purpose can&should inherit this GlobalButtonOrderGenerator.

I am not going to put this in tag of bug because it is functionally correct, but not very fitting in logic in code.

@dnqbob
Copy link
Contributor Author

dnqbob commented Mar 6, 2020

Should we rewrite the GlobalButtonOrderGenerator and it's derived classes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants