Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChromeProvider crash on duplicacted image region #18053

Open
pchote opened this issue May 8, 2020 · 1 comment
Open

ChromeProvider crash on duplicacted image region #18053

pchote opened this issue May 8, 2020 · 1 comment

Comments

@pchote
Copy link
Member

pchote commented May 8, 2020

Testcase: Add a duplicate spectator entry under flags.
Expected behaviour: the second spectator definition overrides the first (this is what happens if the entire flags entry is duplicated, and what we do for traits etc).
Actual behaviour: crash with an unhelpful An item with the same key has already been added. Key: spectator message that doesn't say where it is duplicated.

The current behaviour causes unnecessary problems for modders, and I expect that this should be a one-line fix (changing a .Add call somewhere to an indexed assignment).

@pchote pchote added this to the Next Release milestone May 8, 2020
@Mailaender Mailaender added the UI label May 8, 2020
@abcdefg30 abcdefg30 modified the milestones: Next Release, Next+1 Jun 5, 2020
@pchote pchote removed this from the Next Release milestone Sep 18, 2020
@pchote
Copy link
Member Author

pchote commented Sep 18, 2020

There isn't a simple fix here and IMO the problem isn't worth the overheads in trying to solve it. Removing from the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants