Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainMenuLogic, SetNewsStatus, connection exception not shown. #19684

Closed
anvilvapre opened this issue Sep 24, 2021 · 3 comments · Fixed by #19776
Closed

MainMenuLogic, SetNewsStatus, connection exception not shown. #19684

anvilvapre opened this issue Sep 24, 2021 · 3 comments · Fixed by #19776
Labels

Comments

@anvilvapre
Copy link
Contributor

bleed

During start up news cannot be retrieved on my host. This is correct.

As a result SetNewsStatus($"Failed to retrieve news: {e}"); is called in MainMenuLogic. However I cannot see this message being rendered in the UI anywhere.

The news pull down menu shows 'Battlefields News' and when opening the pull down it shows the I assume default release notes. Not the message or exception stack as string.

How to reproduce: disconnect or block your inet connection, see that no error/fail message is showns that indicates the news could not be retrieved.

@anvilvapre anvilvapre added the Bug label Sep 24, 2021
@abc013
Copy link
Contributor

abc013 commented Oct 26, 2021

For me, it actually shows something:
grafik

Maybe we should use SetNewsStatus($"Failed to retrieve news: {e.Message}"); instead, which would lead to the following result:
grafik

@anvilvapre
Copy link
Contributor Author

bleed?

i noticed when i was working on font.measure. i twas measuring a stack trace that was never shown on screen on my system.

@abc013
Copy link
Contributor

abc013 commented Oct 27, 2021

bleed?

yes.

The news pull down menu shows 'Battlefields News' and when opening the pull down it shows the I assume default release notes. Not the message or exception stack as string.

Thinking about it, news are cached in news.yaml, which means that if the game can't get to the website, it will display the cached message instead. But if there is no cached message, the error (stack trace) will be displayed. I'll file a PR to implement the change I have mentioned before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants