Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fixed in release 2016-10-19) Units get stuck on bridges #7539

Closed
Snurre86 opened this issue Feb 24, 2015 · 10 comments
Closed

(Fixed in release 2016-10-19) Units get stuck on bridges #7539

Snurre86 opened this issue Feb 24, 2015 · 10 comments

Comments

@Snurre86
Copy link

Snurre86 commented Feb 24, 2015

From time to time a vehicle gets stuck on bridges, it might be after giving a new move order as it is passing over a bridge. I have not been able to get units stuck on longer bridges.
dy3fcij

Ok so this is how you reproduce this:

  1. Move the vehicle south of the bridge.
  2. Try to move the vehicle to the cell on the bridge in the picture, it won't go to it directly so move it over the cell then give it a new move order or press "s" (default) as it is in this cell and it gets stuck every time.
    openra game_2015_02_25_10_33_04_371

This happens to infantry as well.

@pevers
Copy link
Contributor

pevers commented Feb 24, 2015

Does the vehicle keep being stuck or will it move if you do another move order?

@abcdefg30
Copy link
Member

It keeps being stuck (I saw this with 3 rifle men somewhen as well).
But I don't have an idea how to reproduce that.
The only thing I know is, that this occurs on repaired bridges.

@ghost
Copy link

ghost commented Feb 24, 2015

Maybe related to #6684.
But here the bridge isn't damaged.

@penev92
Copy link
Member

penev92 commented Feb 25, 2015

With @Snurre86's last update on how to reproduce it, this sounds like a tile metadata issue (walkable terrain). Just guessing, though.

@Snurre86 Snurre86 changed the title Vehicles get stuck on bridges Units get stuck on bridges Feb 25, 2015
@Snurre86
Copy link
Author

Still happens in release 2015-04-24 in mission "survive 02".

@Snurre86
Copy link
Author

Still happens in Release-20151224

@fgdzfggsfgsfgsf
Copy link

Confirmed still happens in 20151224. Also, I think I had 4-5 units stuck on a semi damaged bridge, and I lost all but 1-2 when the bridge was repaired.

@ghost ghost changed the title Units get stuck on bridges Units get stuck on bridges [$21] Feb 4, 2016
@ghost ghost added the Bounty label Feb 4, 2016
@Codes4Fun
Copy link
Contributor

This seems to be related to changeset 3fed98f

If I comment out the change to Bridge.cs, the issue stops happening, I also discovered debugging the code that you don't have to completely blow up the bridge to reproduce the bug, you just need to damage it, which then triggers that code and then you can get stuck on it.

Note also another way you can tell the bug is present is the fact that the unit can't move to that specific tile, that is actually part of the bug.

I don't know what the purpose of that code is, with that code disabled, units didn't cross the bridge when it was blown up, and when engineered repaired it, units could pass over it again, so basically works as expected.

Does OpenRa have a mod that dynamically creates bridges? That would be my only guess as to the purpose of that code.

The code itself seems to replace the bridges tiles with neighbor tiles domain values. So it is pulling the rivers domain value over the bridge.

@Codes4Fun
Copy link
Contributor

I created a pull request 10728 that fixes this issue.

I created 2 test levels, one to test destroying and rebuilding the bridge, and the other for testing when the bridge is initially destroyed and the bridge is repaired.

test_maps.zip

@Mailaender Mailaender removed the Bounty label Nov 10, 2016
@Mailaender Mailaender changed the title Units get stuck on bridges [$21] Units get stuck on bridges Nov 10, 2016
@Snurre86 Snurre86 changed the title Units get stuck on bridges (Fixed in release 2016-10-19) Units get stuck on bridges Nov 21, 2016
@Snurre86
Copy link
Author

Snurre86 commented Nov 21, 2016

Tried it on the bridges in survival 01 mission and it seems fixed in release 2016-10-19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants