Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list.php Can be Spammed #5

Closed
alandoherty opened this issue Nov 5, 2012 · 5 comments · Fixed by #29
Closed

list.php Can be Spammed #5

alandoherty opened this issue Nov 5, 2012 · 5 comments · Fixed by #29
Assignees
Labels

Comments

@alandoherty
Copy link

http://master.open-ra.org/ping.php?port=5354&name=Exploit&state=1&players=0&mods=ra@invalid&map=f1cc766418da45f987690cc6128444ada55d1a89&maxplayers=0

Can be fixed by checking for a custom user agent, suggested to be enforced in next version.

@ihptru
Copy link
Contributor

ihptru commented Mar 16, 2013

you can fake user-agent, it will not fix though

@Mailaender
Copy link
Member

Or maybe have the master server ping back and if the game does not respond remove it from the list. This way it won't list people who forgot to forward their port too.

@alandoherty
Copy link
Author

That would be much more effective

@ihptru
Copy link
Contributor

ihptru commented Mar 17, 2013

there was such fix for it in past: 0e2336f

and such: 33fcd87

@Mailaender
Copy link
Member

I prepared a patch #29 (untested).

@Mailaender Mailaender self-assigned this Dec 6, 2014
Mailaender added a commit to Mailaender/OpenRAMasterServer that referenced this issue Dec 6, 2014
Mailaender added a commit to Mailaender/OpenRAMasterServer that referenced this issue Dec 6, 2014
Mailaender added a commit to Mailaender/OpenRAMasterServer that referenced this issue Dec 6, 2014
Mailaender added a commit to Mailaender/OpenRAMasterServer that referenced this issue Dec 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants