Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Staff Patrol Area clicks #17067

Closed
mynameiskrysta opened this issue Apr 26, 2022 · 4 comments · Fixed by #18329
Closed

Random Staff Patrol Area clicks #17067

mynameiskrysta opened this issue Apr 26, 2022 · 4 comments · Fixed by #18329
Labels
bug Something went wrong.

Comments

@mynameiskrysta
Copy link

Operating System

Windows 10 64 bit

OpenRCT2 build

OpenRCT2, v0.4.0 (c6302a1 on master) provided by GitHub

Describe the issue

when selecting the patrol area, and doing certain things, there'll be a random click of tiles somewhere on the screen to select those as the patrol area. Also when

Area(s) with issue?

No response

Steps to reproduce

  1. choose patrol area for any staff member and close a window
  2. the click to close the window will add a random 4x4 square of tiles selected for the patrol area, sometimes behind where the mouse is, sometimes in a seemingly random place

also

  1. go to choose patrol area for any staff, with some staff patrol tiles already placed
  2. click on one of the already placed gray selected tiles and the click will count as if you're adding tiles instead of just checking what staff member those tiles belong to

Attachments

No response

@mynameiskrysta mynameiskrysta added the bug Something went wrong. label Apr 26, 2022
@ocalhoun6
Copy link
Contributor

click on one of the already placed gray selected tiles and the click will count as if you're adding tiles instead of just checking what staff member those tiles belong to

Isn't this part normal intended operation?

Sometimes you want to assign multiple handymen to the same tile.

@mynameiskrysta
Copy link
Author

mynameiskrysta commented Apr 27, 2022 via email

@Derpercoaster
Copy link

I see this issue too. I've also seen over half of my park suddenly become assigned to the staff's patrol area. Seems to me that the best solution is to not automatically turn on patrol area painting when clicking thhe "locate staff" button.

@raacker
Copy link
Contributor

raacker commented Oct 12, 2022

bug

Bug confirmed. It seems like it really shouldn't do any action if the tile has no patrol mark.

Hopping in to fix the issue!

raacker added a commit to raacker/OpenRCT2 that referenced this issue Oct 13, 2022
Clicking the tile with Global Patrol area enabled still fires OnToolDrag but the problem is that PatrolAreaWindow tool is not fully initialized with other attributes especially gMapSelectPositionA, B.

To avoid the uninitialized call behavior, add a None enum which only sets when the tool is ready to act.
raacker added a commit to raacker/OpenRCT2 that referenced this issue Oct 13, 2022
Clicking the tile with Global Patrol area enabled still fires OnToolDrag but the problem is that PatrolAreaWindow tool is not fully initialized with other attributes especially gMapSelectPositionA, B.

To avoid the uninitialized call behavior, add a None enum which only sets when the tool is ready to act.
@Gymnasiast Gymnasiast linked a pull request Oct 13, 2022 that will close this issue
raacker added a commit to raacker/OpenRCT2 that referenced this issue Oct 14, 2022
Clicking the tile with Global Patrol area enabled still fires OnToolDrag but the problem is that PatrolAreaWindow tool is not fully initialized with other attributes especially gMapSelectPositionA, B.

To avoid the uninitialized call behavior, add a None enum which only sets when the tool is ready to act.
raacker added a commit to raacker/OpenRCT2 that referenced this issue Nov 10, 2022
raacker added a commit to raacker/OpenRCT2 that referenced this issue Nov 10, 2022
raacker added a commit to raacker/OpenRCT2 that referenced this issue Nov 13, 2022
tupaschoal added a commit that referenced this issue Nov 16, 2022
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
Gymnasiast added a commit that referenced this issue Dec 14, 2022
- Feature: [#17782] The Flying Coaster now has access to boosters and can draw outside loops.
- Feature: [#17997] The Log Flume can now draw steep pieces down (if vehicle allows it).
- Feature: [#18312, objects#220, OpenSFX#13] New sound effects for the Hybrid and Single Rail roller coasters.
- Feature: [#18675] [Plugin] Plugins can refer to g2 image icons by name.
- Feature: [objects#173] Add alpine coaster vehicle.
- Feature: [objects#221] Add two extra jungle walls.
- Feature: [objects#225] Add log cabin roofs.
- Feature: [OpenMusic#14, OpenMusic#15, OpenMusic#18] Added Galaxy, Acid and Dodgems ride music styles.
- Improved: [#18013, #18016, #18018, #18019, #18514, objects#224] Added colour presets to Spiral Slide, Dodgems, Boat Hire, Flying Saucers, and Car Ride.
- Improved: [#18024] Clearer error messages when loading incompatible .park files.
- Improved: [#18192] Tycoon Park has been added to the Extras tab.
- Improved: [#18214] Competition scenarios have received their own section.
- Improved: [#18250] Added modern style file and folder pickers on Windows.
- Improved: [#18332] Allow Inverted Roller Coaster to draw boosters.
- Improved: [#18350] Changed ride vehicle list to have less padding.
- Improved: [#18422] Allow adding images to music objects.
- Improved: [#18428] [Plugin] Add widget description interfaces to documentation.
- Improved: [#18487] Mini Helicopters track can now draw spinning tunnels.
- Improved: [#18591] Order RollerCoaster Tycoon 2 scenarios by difficulty.
- Improved: [#18607] A new tab for all UCES Scenarios, if it’s installed.
- Improved: [#18621] OpenGL performance.
- Change: [#17677] Open campaign window from finished campaign news.
- Change: [#17998] Show cursor when using inverted mouse dragging.
- Change: [#18230] Make the large flat to steep pieces available on the corkscrew roller coaster without cheats.
- Change: [#18381] Convert custom invisible paths to the built-in ones.
- Change: [OpenSFX#11, OpenMusic#19] First implementation of official replacement asset packs for sound effects & music.
- Fix: [#1491] Clearance of the Cash Machine is too low (original bug).
- Fix: [#1519] “See-through rides” doesn't affect all rides (original bug).
- Fix: [#6341] “Unlock vehicle limits” does not allow setting fewer vehicles than the vehicle type requires.
- Fix: [#14312] Research ride type message incorrect.
- Fix: [#14425] Ride ratings do not skip unallocated ride ids.
- Fix: [#15969] Guests heading for ride use vanilla behaviour
- Fix: [#17067] Random Staff Patrol Area clicks.
- Fix: [#17316] Sides of River Rapids’ corners overlay other parts of the track.
- Fix: [#17657] When switching from buying land rights to buying construction rights, grid disables and won't re-enable afterwards.
- Fix: [#17763] Missing validation on invalid characters in file name.
- Fix: [#17853] Invention name tears while being dragged.
- Fix: [#18064] Unable to dismiss notification messages.
- Fix: [#18070] Underground entrance/exit shows through terrain walls (original bug).
- Fix: [#18094] Underground shops & facilities don't show when adjacent to non-underground path (original bug).
- Fix: [#18122] Ghosts count towards “Great scenery!” guest thought.
- Fix: [#18134] Underground on-ride photo section partially clips through adjacent terrain edge.
- Fix: [#18244] Invention DragWindow's starting position is inconsistent.
- Fix: [#18245] Guests stopping dead in their tracks at railway crossings.
- Fix: [#18257] Guests ‘waiting’ on extended railway crossings.
- Fix: [#18354] Overwrite alert does not show when save name has different casing on Windows.
- Fix: [#18379] Tunnel entrances for underground Mini Golf Hole E are not rendered correctly.
- Fix: [#18442] About window background is clickable.
- Fix: [#18449] [Plugin] Change type of listview widgets from 'scroll_view' to 'listview'.
- Fix: [#18453] Slow walking guests don't get across level crossings in time.
- Fix: [#18469] Land rights window buttons incorrectly disabled and markers remain visible indefinitely.
- Fix: [#18459] ‘Highlight path issues’ hides fences for paths with additions.
- Fix: [#18552] Trains clipping through helixes.
- Fix: [#18576] Cannot open parks with certain types of corrupt tile elements.
- Fix: [#18606] JSON objects do not take priority over the DAT files they supersede.
- Fix: [#18620] [Plugin] Crash when reading widget properties from windows that have both static and tab widgets.
- Fix: [#18653] Negative ratings multipliers do not appear in Vehicle tab.
- Fix: [#18696] Construction rights cannot be viewed after all are purchased.
- Fix: [#18720] Upwards helix is enabled for the Alpine Coaster, even when cheats are off.
- Fix: [#18755] Ferris Wheel and Circus ghosts not coloured correctly.
- Fix: [#18802] Game could crash when determining if a mechanic is heading to fix the ride blocking the path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants