You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #19247 unconditionally forces the download of OpenMusic and OpenSoundEffects, even if cmake is passed an option like -DDOWNLOAD_OPENMSX=OFF. Please fix the cmake logic to respect options that may be set when invoking cmake.
Steps to reproduce
Build on a host without Internet access, and observe that -DDOWNLOAD_OPENSFX=OFF -DDOWNLOAD_OPENMSX=OFF has no effect:
This change removes the hardcoded enable for Linuxsystems, where
DOWNLOAD_OPENMSX and DOWNLOAD_OPENSFX is always set to ON and as a
result overwriting users choice not to download those files.
This fixesOpenRCT2#19763
Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
Operating System
Debian sid
OpenRCT2 build
0.4.4
Base game
RollerCoaster Tycoon 2
Area(s) with this issue?
Issues building the game
Describe the issue
PR #19247 unconditionally forces the download of OpenMusic and OpenSoundEffects, even if cmake is passed an option like
-DDOWNLOAD_OPENMSX=OFF
. Please fix the cmake logic to respect options that may be set when invoking cmake.Steps to reproduce
Build on a host without Internet access, and observe that
-DDOWNLOAD_OPENSFX=OFF -DDOWNLOAD_OPENMSX=OFF
has no effect:Attachments
No response
The text was updated successfully, but these errors were encountered: