Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable download of OpenMusic and OpenSoundEffects in Linux builds #19763

Closed
gibmat opened this issue Mar 29, 2023 · 0 comments · Fixed by #19796
Closed

Cannot disable download of OpenMusic and OpenSoundEffects in Linux builds #19763

gibmat opened this issue Mar 29, 2023 · 0 comments · Fixed by #19796
Labels
bug Something went wrong.

Comments

@gibmat
Copy link
Contributor

gibmat commented Mar 29, 2023

Operating System

Debian sid

OpenRCT2 build

0.4.4

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

Issues building the game

Describe the issue

PR #19247 unconditionally forces the download of OpenMusic and OpenSoundEffects, even if cmake is passed an option like -DDOWNLOAD_OPENMSX=OFF. Please fix the cmake logic to respect options that may be set when invoking cmake.

Steps to reproduce

Build on a host without Internet access, and observe that -DDOWNLOAD_OPENSFX=OFF -DDOWNLOAD_OPENMSX=OFF has no effect:

Downloading /build/openrct2-0.4.4+ds/debian/tmp/usr/share/openrct2/
CMake Error at /build/openrct2-0.4.4+ds/cmake/download.cmake:33 (file):
  file DOWNLOAD HASH mismatch

    for file: [/build/openrct2-0.4.4+ds/debian/tmp/usr/share/openrct2//opensound.zip]
      expected hash: [64ef7e0b7785602c91aec66f005c035b05a2133b]
        actual hash: [da39a3ee5e6b4b0d3255bfef95601890afd80709]
             status: [6;"Couldn't resolve host name"]

Call Stack (most recent call first):
  cmake_install.cmake:52 (download_openrct2_zip)

Attachments

No response

@gibmat gibmat added the bug Something went wrong. label Mar 29, 2023
ConiKost added a commit to ConiKost/OpenRCT2 that referenced this issue Apr 1, 2023
This change removes the hardcoded enable for Linuxsystems, where
DOWNLOAD_OPENMSX and DOWNLOAD_OPENSFX is always set to ON and as a
result overwriting users choice not to download those files.

This fixes OpenRCT2#19763
Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
@ZehMatt ZehMatt closed this as completed in d4a803e Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant