Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOs tests running without OpenMusic #19827

Closed
karst opened this issue Apr 4, 2023 · 2 comments
Closed

MacOs tests running without OpenMusic #19827

karst opened this issue Apr 4, 2023 · 2 comments
Labels
bug Something went wrong.

Comments

@karst
Copy link
Member

karst commented Apr 4, 2023

Operating System

CI / macOS (x64) using CMake

OpenRCT2 build

PR 19785 (Built on v0.4.4-81fd7b6)

Base game

RollerCoaster Tycoon 2, RollerCoaster Tycoon Classic

Area(s) with this issue?

No response

Describe the issue

#19785 is failing because OpenMusic isn't loaded in with tests

Steps to reproduce

Check the PR

Attachments

No response
@karst karst added the bug Something went wrong. label Apr 4, 2023
@karst karst mentioned this issue Apr 5, 2023
Merged
@karst
Copy link
Member Author

karst commented Jun 20, 2023

@duncanspumpkin i noticed that the PR is now no longer failing. Was this issue fixed with the most recent push to that PR, or has it been fixed on develop?

@ZehMatt
Copy link
Member

ZehMatt commented Jun 20, 2023

It was probably fixed by the cmake PR that I recently merged

@karst karst closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karst @ZehMatt