Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select OpenMusic by default when opening a new scenario #19785

Merged
merged 4 commits into from Aug 28, 2023
Merged

Select OpenMusic by default when opening a new scenario #19785

merged 4 commits into from Aug 28, 2023

Conversation

karst
Copy link
Member

@karst karst commented Mar 30, 2023 •
edited

As requested on Reddit. Idk how people feel about this, feel free to discuss.

Depends on #19827

@karst karst mentioned this pull request Mar 30, 2023
Merged
@karst
Copy link
Member Author

karst commented Mar 30, 2023

idk why macos is failing, but i am pretty certain it doesn't have anything to do with this pr.

@IntelOrca
Copy link
Contributor

macOS tests are failing as it doesn't seem to have the OpenRCT2 music objects when running the tests.

@karst
Copy link
Member Author

karst commented Apr 4, 2023

Guess a fix for that would have to be merged first eh

@karst karst mentioned this pull request Apr 4, 2023
Closed
@karst karst marked this pull request as draft April 5, 2023 14:12
@karst karst marked this pull request as ready for review April 5, 2023 14:33
@github-actions github-actions bot added the requires dependency Another change should be merged first. label Apr 5, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@karst

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the stale-pr label May 8, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@karst

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed stale-pr requires dependency Another change should be merged first. labels Jun 21, 2023
@github-actions
Copy link

This PR/issue depends on:

@github-actions
Copy link

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@karst
Copy link
Member Author

karst commented Jul 23, 2023

I would still like to see this implemented

@github-actions github-actions bot removed the stale-pr label Jul 24, 2023
@github-actions
Copy link

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@karst
Add OpenMusic to DefaultObjects
0dafa3c 
This adds all OpenMusic to be included when creating a new scenario.
@karst
Amend changelog
dca49cc
@github-actions github-actions bot removed the stale-pr label Aug 26, 2023
@karst
Copy link
Member Author

karst commented Aug 26, 2023

Would be nice for OpenMusic to have this in before next release. Should be ready.

Once this is in I'll update guidelines for adding new songs/creating new OpenMusic releases.

@ZehMatt ZehMatt added this to the v0.4.6 milestone Aug 27, 2023
Broxzier
Broxzier approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@Broxzier Broxzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the build, and everything seems to be in order

@ZehMatt ZehMatt merged commit b56d8a5 into OpenRCT2:develop Aug 28, 2023
21 checks passed
@Broxzier Broxzier deleted the openmusic-default branch August 31, 2023 08:07
janisozaur added a commit that referenced this pull request Sep 3, 2023
@janisozaur
Release v0.4.6
b40b5da 
- Feature: [#15660] Ability to show window buttons on the left.
- Feature: [#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [#20119, #20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [#20393, #20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [#19735] Server unable to advertise to master server after a connection loss.
- Fix: [#19822] Tile inspector does not deep copy banners.
- Fix: [#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [#20089] Potential crash when a window is closed from another window.
- Fix: [#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [#20310] Map animations are not created on the title screen.
- Fix: [#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [#20361] Crash when using random map generation.
- Fix: [#20364] Adding too much money with cheats causes an overflow.
- Fix: [#20365] Money cheat input does not support negative values.
- Fix: [#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [#20413] Crash when attempting to navigate an empty console history.
- Fix: [#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [#20429] Error window tooltip not closing after 8 seconds.
- Fix: [#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [#20484] Console caret not properly updated when using command history.
- Fix: [#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [#20543] Crash using show segments height from debug paint options.
- Fix: [#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [#20659] Phantom rides remain when closing construction window while paused.
- Fix: [#20672] Maze ghost elements incorrectly displayed.
- Fix: [#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [#20739] Build version info on title screen leaving stray pixels when the camera is moved.
krrg pushed a commit to krrg/OpenRCT2 that referenced this pull request Sep 14, 2023
@janisozaur @krrg
Release v0.4.6
355de33 
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
Realsteel89 pushed a commit to Realsteel89/OpenRCT2 that referenced this pull request Oct 10, 2023
@janisozaur @Realsteel89
Release v0.4.6
ba907b0 
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
Realsteel89 pushed a commit to Realsteel89/OpenRCT2 that referenced this pull request Oct 15, 2023
@janisozaur @Realsteel89
Release v0.4.6
ba6c7d0 
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
@AaronVanGeffen AaronVanGeffen mentioned this pull request Dec 3, 2023
Open
AT41 pushed a commit to AT41/OpenRCT2 that referenced this pull request Dec 24, 2023
@janisozaur
Release v0.4.6
5ba6a15 
- Feature: [OpenRCT2#15660] Ability to show window buttons on the left.
- Feature: [OpenRCT2#20680] New title sequences (https://github.com/OpenRCT2/title-sequences/releases/tag/v0.4.6).
- Feature: [OpenMusic#41] Official Title Theme by Allister Brimble.
- Improved: [OpenRCT2#20119, OpenRCT2#20243] Add new colour presets to several roller coasters (using the new colours).
- Improved: [OpenRCT2#20393, OpenRCT2#20410] Add Cyrillic characters Ґґ, Ѕѕ, Єє, Іі, Її, and Јј to the sprite font.
- Change: [OpenRCT2#19785] OpenMusic is now selected by default when opening SC4/SC6 - or creating new - scenarios.
- Change: [OpenRCT2#20110] Fix a few RCT1 build height parity discrepancies.
- Change: [OpenRCT2#20550] Change SEK conversion rate from 1 GBP to 0.1 GBP.
- Fix: [OpenRCT2#6152] Camera and UI are no longer locked at 40 Hz, providing a smoother experience.
- Fix: [OpenRCT2#9534] Screams no longer cut-off on steep diagonal drops.
- Fix: [OpenRCT2#17666] Using the mountain tool near the edge of the map with clearance checks disabled causes visual glitches.
- Fix: [OpenRCT2#19450] The correct element is now auto-suggested when building a Medium Half Loop backwards.
- Fix: [OpenRCT2#19735] Server unable to advertise to master server after a connection loss.
- Fix: [OpenRCT2#19822] Tile inspector does not deep copy banners.
- Fix: [OpenRCT2#19823] Parkobj: disallow overriding objects of different object types.
- Fix: [OpenRCT2#19878] Unresearched scenery can be placed via prebuilt rides.
- Fix: [OpenRCT2#20083] Cannot use terrain surfaces with ID > 32 and terrain edges with ID > 16.
- Fix: [OpenRCT2#20089] Potential crash when a window is closed from another window.
- Fix: [OpenRCT2#20103] [Plugin] Crash when custom plugin actions fail due to immutable state.
- Fix: [OpenRCT2#20111] All coaster types can access the new diagonal slope pieces.
- Fix: [OpenRCT2#20155] Fairground organ style 2 shows up as regular music, rather than for the merry-go-round.
- Fix: [OpenRCT2#20260] Ride locks up when inspecting/fixing staff member is fired.
- Fix: [OpenRCT2#20262] Title screen music missing when “random” title music is selected and RCT1 is no longer linked.
- Fix: [OpenRCT2#20310] Map animations are not created on the title screen.
- Fix: [OpenRCT2#20342] Large Half Loop (left) now only appears once in the special elements dropdown.
- Fix: [OpenRCT2#20361] Crash when using random map generation.
- Fix: [OpenRCT2#20364] Adding too much money with cheats causes an overflow.
- Fix: [OpenRCT2#20365] Money cheat input does not support negative values.
- Fix: [OpenRCT2#20389] Reversed vehicles are now correctly banked on diagonal slopes.
- Fix: [OpenRCT2#20413] Crash when attempting to navigate an empty console history.
- Fix: [OpenRCT2#20417] Plugin/custom windows are missing the left border in the title bar.
- Fix: [OpenRCT2#20429] Error window tooltip not closing after 8 seconds.
- Fix: [OpenRCT2#20456] Downward large half loops on flying coasters (fly-to-lie) are now correctly named.
- Fix: [OpenRCT2#20484] Console caret not properly updated when using command history.
- Fix: [OpenRCT2#20496] Ride rating requirements for compact inverted coasters is no longer relaxed.
- Fix: [OpenRCT2#20543] Crash using show segments height from debug paint options.
- Fix: [OpenRCT2#20607] Infinite loop when renaming rides with default names longer than 32 bytes.
- Fix: [OpenRCT2#20642] Track list is sometimes empty due to uninitialized data for the filter string.
- Fix: [OpenRCT2#20659] Phantom rides remain when closing construction window while paused.
- Fix: [OpenRCT2#20672] Maze ghost elements incorrectly displayed.
- Fix: [OpenRCT2#20684] Footpath additions getting removed by Miniature railway ghost elements.
- Fix: [OpenRCT2#20693] Incorrect information shown when hovering over station when another station before it was removed.
- Fix: [OpenRCT2#20739] Build version info on title screen leaving stray pixels when the camera is moved.
oxzi added a commit to oxzi/nixpkgs that referenced this pull request Jan 13, 2024
@oxzi
openrct2: 0.4.5 -> 0.4.7
40cc9e4 
- https://github.com/OpenRCT2/OpenRCT2/releases/tag/v0.4.6
- https://github.com/OpenRCT2/OpenRCT2/releases/tag/v0.4.7

Updating to 0.4.6 resulted some headaches, as suddenly lots of errors
about missing music objects were thrown and old maps were not loadable.
This was also mentioned in NixOS#263025.

Today I git bisect'ed OpenRCT2's source between 0.4.5 and 0.4.6, finding
5adbea9ac829b76507543e4c09b2000138ffbbcf as the culprit, which origins
in OpenRCT2/OpenRCT2#19785. From there I got to OpenRCT2/OpenRCT2#21043
which addresses this very issue and fixes it by undoing the original
change next to some later changes. This PR is now included as a patch
and, et voilà, OpenRCT2 works again!

Closes NixOS#263025.
@oxzi oxzi mentioned this pull request Jan 13, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanspumpkin duncanspumpkin duncanspumpkin left review comments

@ZehMatt ZehMatt ZehMatt approved these changes

@Broxzier Broxzier Broxzier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@karst @IntelOrca @duncanspumpkin @ZehMatt @Broxzier