OpenRCT2 draws supports in places where vanilla wouldn't

[Liampie]

So I noticed while looking at some older parks that a coaster's supports where showing, where they should be blocked. I don't think this has always been a problem with OpenRCT. I guess it has something to do with the drawing order on those tiles?

I took two screens of the exact same thing in the exact (pixel perfect) location. A high quality gif alternating between the two would make the differences clear, but I don't know how to do that, so I'll just upload the two .pngs I have, and you have to do the alternating yourself if you download them...

Note the flying coaster supports, but also the tram supports.

The park in question: Dimi - Värmland Park.zip
https://www.nedesigns.com/park/1869/vaermland-park/

Using v0.2.1-600 (92412d4) on Windows 8

[AaronVanGeffen]

Hmm, that does look a little overzealous. Something to do with detecting the custom supports, maybe?

[Liampie]

The custom supports likely have nothing to do with it, they rarely influence the coaster's supports, especially in this case as the track is inverted, meaning that the supports are on the side on an entirely different tile. Besides, the tram is also affected even when there isn't a coaster near it (see top of screen for example)

[tomlankhorst]

https://ezgif.com

I think that it is interesting how it's only one specific type of support that is added to the coaster.

[Liampie]

I found two more examples:

https://www.nedesigns.com/park/714/barkwood-amusement-park/

Very noticable here, maybe a better park to use to figure out what's wrong:
https://www.nedesigns.com/park/605/jetstream/

[duncanspumpkin]

Make a minimal map that suffers from the bug. I don't want anything apart from the scenery that is not causing the block and the track. The examples from this are too complex and I don't know enough about how it is meant to work to make a minimal version.

[Liampie]

Make a minimal map that suffers from the bug. I don't want anything apart from the scenery that is not causing the block and the track. The examples from this are too complex and I don't know enough about how it is meant to work to make a minimal version.

Only just saw this message. I isolated the differences between vanilla and Open, as shown in the screens above, in this savegame:

supportsbug.zip

[duncanspumpkin]

For reference this is OpenRCT2 as of 30/07/21

And this is vanilla RCT2

Its clear that the base supports have not been drawn. Also the quadrant it is drawn in is different but that might just be the base support not being there causing that.

[duncanspumpkin]

8601S.zip
This is a super minimal save that suffers from the bug. Loads fine in vanilla and OpenRCT2.

[duncanspumpkin]

ARGHHH can't believe i went round and round in so many circles and its something super obvious:

    // ToonTowner's base blocks. Make them allow supports on top and put them in the Walls and Roofs group.
    if (identifier == "XXBBCL01" ||
        identifier == "XXBBMD01" ||
        identifier == "ARBASE2 ")
    {
        SetPrimarySceneryGroup(scgWalls);

        _legacyType.flags |= SMALL_SCENERY_FLAG_BUILD_DIRECTLY_ONTOP;
    }

[Gymnasiast]

This is not a bug. All vanilla base blocks allow supports on top, and so I fixed ToonTowner’s base blocks to also allow them. The bug is that TT forgot to set that flag on his objects in the first place.

Edit: closed it by accident.

[Liampie]

I don't think OpenRCT should concern itself with the properties of custom objects, it's outside the realm of what OpenRCT sets out to do.