Audio clean-up and style/usage fixes

[tomlankhorst]

• use appropriate static casts
• use appropriate dynamic cast
• remove unused headers
• mark 'pure' getters as 'nodiscard'
• remove redundant virtual
• mark override
• default initialize some structs

[tomlankhorst]

I might be making a mistake... but Travis' clang-format seems to be inconsistent with mine.

[AaronVanGeffen]

Travis' clang-format seems to be inconsistent with mine.

We're probably still using an old version of clang-format. I think we have to manually update, and it's been a while.

[tomlankhorst]

@AaronVanGeffen Seems @IntelOrca did the latest docker image update of openrct2/openrct2:format. Maybe he can run a docker build, docker push? Or even better, we automate it.

[janisozaur]

That's not the right way to do. Build a static version of clang-format or use one already available in angular repos, don't build full OS just for that. I will eventually do that, once I have some more time.

[tomlankhorst]

@janisozaur Actually, building an image for a single executable is a typical use-case. And although the openrct2/openrct2:format includes many packages that are not used, the corresponding image layers will be reused from other openrct2/openrct2 images. It's not a full-blown OS in the end, it's just some namespacing with about 3 MB of supporting binaries (in the case of Alpine).

Take unibeautify/clang-format for example, it's just 33 MB in total.

[IntelOrca]

don't build full OS just for that

OS implies a having a kernel right? That is no kernel building involved with docker. As @tomlankhorst pointed out, docker has always intended to be for running single apps, such as web apps.

[Gymnasiast]

@tomlankhorst Do you plan to continue work on this PR?

[tupaschoal]

I was going to review, but the builds are failing, please take a look :)

[tomlankhorst]

I was going to review, but the builds are failing, please take a look :)

Sorry for the delay. I try to fix it today.

[tupaschoal]

No problem/rush, I just didn't know if you saw it, so I commented

[Gymnasiast]

I think this should have been split into multiple parts. Some of the plain fixes (like [nodiscard]) are likely to be merged with very little discussion, while other things might take a long time.

[tupaschoal]

I think it's good to go with the suggestions