Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor more TileCoords #10875

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Refactor more TileCoords #10875

merged 2 commits into from
Mar 7, 2020

Conversation

Gymnasiast
Copy link
Member

Also converts a lot of Z calculation to use big Zs.

@Gymnasiast Gymnasiast requested review from tupaschoal and duncanspumpkin and removed request for tupaschoal March 5, 2020 12:17
tupaschoal
tupaschoal approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, though I reviewed on the phone

duncanspumpkin
duncanspumpkin requested changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@duncanspumpkin duncanspumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

src/openrct2/actions/MazePlaceTrackAction.hpp Outdated Show resolved Hide resolved
src/openrct2/actions/MazeSetTrackAction.hpp Outdated Show resolved Hide resolved
src/openrct2/actions/MazeSetTrackAction.hpp Outdated Show resolved Hide resolved
src/openrct2/actions/MazeSetTrackAction.hpp Outdated Show resolved Hide resolved
src/openrct2/actions/TrackPlaceAction.hpp Outdated Show resolved Hide resolved
src/openrct2/actions/TrackPlaceAction.hpp Outdated Show resolved Hide resolved
Gymnasiast
Gymnasiast commented Mar 7, 2020
View reviewed changes
Copy link
Member Author

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge this yet - I have to test some stuff regarding maximum heights that don't seem to work correctly.

@Gymnasiast
Copy link
Member Author

OK, solved the bug I encountered.

@Gymnasiast Gymnasiast merged commit be13c1f into OpenRCT2:develop Mar 7, 2020
@Gymnasiast Gymnasiast deleted the refactor/more-coords branch March 7, 2020 20:07
@tupaschoal tupaschoal mentioned this pull request Mar 16, 2020
Merged
@Gymnasiast Gymnasiast mentioned this pull request Mar 29, 2020
Closed
2 tasks
@janisozaur janisozaur mentioned this pull request Mar 31, 2020
Closed
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this pull request Mar 31, 2020
@Gymnasiast
Fix mistake with wall coordinates in OpenRCT2#10875
ac58e2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanspumpkin duncanspumpkin duncanspumpkin requested changes

@tupaschoal tupaschoal tupaschoal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gymnasiast @duncanspumpkin @tupaschoal