Fix #7094: Back wall edge texture in water missing #11061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Sides are drawn wrong on one rotation, others are fine:
|
|
@Umdlye I think I have solved that one too :) |
|
Looks good now! One small issue remains, was in the original game as well. Not sure if it's outside the scope of this PR.
|
|
Not sure if that's an issue/bug in the first place. |
|
No issues here, it works how you would expect when you hide the vertical faces as well. |
Umdlye
reviewed
Mar 26, 2020
tupaschoal
reviewed
Mar 26, 2020
That and the division by 8 instead of 16. Together they ensured no back wall was ever drawn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is a tiny refactor. Second commit contains the fix. Recommend viewing them one by one.