Remove custom_info pointer #20480
Merged
Remove custom_info pointer #20480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanspumpkin
force-pushed
the
removeCustomInfo
branch
from
2d3fb5d
to
f71055c
Compare
duncanspumpkin
force-pushed
the
removeCustomInfo
branch
from
f71055c
to
eb90dee
Compare
ZehMatt
approved these changes
Jul 17, 2023
Did you test with a plugin that has a tabbed window? |
mrmbernardi
pushed a commit
to mrmbernardi/OpenRCT2
that referenced
this pull request
Jul 22, 2023
* Remove custom_info pointer * Formatting
X123M3-256
pushed a commit
to X123M3-256/OpenRCT2
that referenced
this pull request
Jul 23, 2023
* Remove custom_info pointer * Formatting
Realsteel89
pushed a commit
to Realsteel89/OpenRCT2
that referenced
this pull request
Oct 10, 2023
* Remove custom_info pointer * Formatting
AT41
pushed a commit
to AT41/OpenRCT2
that referenced
this pull request
Dec 24, 2023
* Remove custom_info pointer * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was slightly convoluted to remove but I think its all done safely. Would be good to verify with a few plugins that i haven't broken anything.
I removed the initialize function so the custom info doesn't need dynamic allocated and all of the pointer part of it isn't required.
Related to #20429