Do not add new music styles to old parks automatically #21043
Conversation
Gymnasiast
changed the title
|
This appears to have been added intentionally: #19785 |
|
This was an intentional change, and it's currently also part of the release checklist for openmusic. |
|
If you can somehow separate it from SV6/SV4 idm, but for the scenarios I definitely would like to keep it this way. The reason we decided on enabling them by default is because it doesn't change anything balance wise about the game, and it used to not be an object type, but you were able to add two custom music tracks without cheating. |
|
I understand the reasoning, but I still think it would be wise to reconsider. I think it should only be done for new scenarios. But if the general opinion of the players is that it should be kept, I’m not going to kick up a fuss. (Not that I should do so anyway.) |
|
Adding to saved games was not intentional (otherwise it would have mentioned SV4/SV6 in the changelog). |
|
I meant that I think that the new music styles should only be selected when creating a new scenario, and loading from a SV4/SC4/SV6/SC6 should not. That is what my PR does, so from that perspective this PR does fix it. But judging from the reactions, I doubt many people would agree. |
|
Oh okay, it is cleaner to not add the stuff... But I guess the problem is that people kept asking how they add the new music. Not enough people seem to be aware or familiar with the object selection window and it is a bit of hack to do something fairly common. Do you have some alternative solutions? |
|
I think it would be a good idea to make it easier for the user to add new music styles to any game. E.g. have a button near the music dropdown to add more styles (which would then show the whole list of installed music, allowing the user to just pick a few extra ones). That would work for any style, not just official ones. I think that is a better solution overall, it gives the user more control over their saves while also making it easier for them to add new music, regardless of where it comes from. |
|
I like that idea. Could be done after #20980 is merged. |
Might be nice to have a simplified/easy method for adding objects in general, not just for music... (Maybe a plugin could do this?) Like in a few different windows:
In each of those windows, somewhere in the UI, you could put a [+] or "Get more" button. And if you click that button, it opens a simplified version of the object selection window, showing only objects of that type and only allowing you to add more objects of that type, with all the other features of the object selection window hidden behind an 'advanced mode' button that would open up the full object selection window. That would be easy to use and fairly intuitive -- anywhere you see a selection of objects to use in your park, you could have the [+] button somewhere next to it, which allows to to add more options to be used for that type of object. |
- https://github.com/OpenRCT2/OpenRCT2/releases/tag/v0.4.6 - https://github.com/OpenRCT2/OpenRCT2/releases/tag/v0.4.7 Updating to 0.4.6 resulted some headaches, as suddenly lots of errors about missing music objects were thrown and old maps were not loadable. This was also mentioned in NixOS#263025. Today I git bisect'ed OpenRCT2's source between 0.4.5 and 0.4.6, finding 5adbea9ac829b76507543e4c09b2000138ffbbcf as the culprit, which origins in OpenRCT2/OpenRCT2#19785. From there I got to OpenRCT2/OpenRCT2#21043 which addresses this very issue and fixes it by undoing the original change next to some later changes. This PR is now included as a patch and, et voilà, OpenRCT2 works again! Closes NixOS#263025.
|
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
keep open |
|
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
For some reason, newly introduced music styles were added to existing SV4 and SV6 files. This didn’t make a great deal of sense, as we always leave the object selection intact as much as possible. (E.g. we don’t add new land types or station styles or anything else either.)
While investigating, it also seems like SV4, SV6, TD4 and TD6 loading still assumes that the music IDs are fixed, which hasn’t been the case for a long time. This is something I’d want to investigate further and maybe address in a future PR.