Fix #21434: Number of guests overflows in objective text #21518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kelemen
force-pushed
the
fix_guest_objective_display_overflow
branch
from
ae4af45
to
e9977d1
Compare
jan-kelemen
force-pushed
the
fix_guest_objective_display_overflow
branch
2 times, most recently
from
2b2c91c
to
a56ae7d
Compare
|
Resolved review comment, rebased to develop to resolve conflicts. |
duncanspumpkin
approved these changes
Mar 14, 2024
Gymnasiast
approved these changes
Mar 14, 2024
jan-kelemen
force-pushed
the
fix_guest_objective_display_overflow
branch
from
a56ae7d
to
204e23a
Compare
|
Changelog entry added. |
jan-kelemen
force-pushed
the
fix_guest_objective_display_overflow
branch
from
204e23a
to
ce17952
Compare
Gymnasiast
reviewed
Mar 14, 2024
jan-kelemen
force-pushed
the
fix_guest_objective_display_overflow
branch
from
ce17952
to
e47400b
Compare
Gymnasiast
approved these changes
Mar 14, 2024
|
@jan-kelemen Could you also create a PR against the Localisation repository that replaces the formatting token in all other languages? |
|
@Gymnasiast yup, done OpenRCT2/Localisation#2787 |
Gymnasiast
pushed a commit
to OpenRCT2/Localisation
that referenced
this pull request
Mar 14, 2024
Gymnasiast
added a commit
to Gymnasiast/OpenRCT2
that referenced
this pull request
Mar 22, 2024
OpenRCT2#21518 made some changes to objective formatting, but forgot to update the scenario selector. This PR addresses this, and also moves the code into a function of its own to reduce code duplication and prevent this problem in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format number of guests in objective as Comma32 instead of Comma16.
Fixes [#21434]