-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #21426: Save currently following entity into save file. #21656
base: develop
Are you sure you want to change the base?
Feature #21426: Save currently following entity into save file. #21656
Conversation
b434b27
to
7a7d775
Compare
7a7d775
to
f7fa19b
Compare
50a0590
to
f40f0f6
Compare
ce4abd5
to
a9596fd
Compare
a9596fd
to
9068ea0
Compare
d5d7b3a
to
51d1a59
Compare
51d1a59
to
4fe5aca
Compare
8a79f6c
to
688b179
Compare
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
please keep open |
688b179
to
cd46aad
Compare
cd46aad
to
a040c7c
Compare
@@ -363,6 +363,12 @@ void GameLoadInit() | |||
auto& gameState = GetGameState(); | |||
windowManager->SetMainView(gameState.SavedView, gameState.SavedViewZoom, gameState.SavedViewRotation); | |||
|
|||
if (gameState.CurrentlyFollowingEntity != EntityId::GetNull()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is where the code should go. It's ultimately a ui property so it should be in the ui library. Saying that i don't know where i would place it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it could go in the SetMainView
function in WindowManager.cpp?
I'm a bit hesitant on this PR, I think the scripting API has enough functionality to do this entirely with a plugin. |
Implements feature requested in #21426 and saves the currently following entity into the save file. Works with all entities (rollercoasters, peeps etc).