Fix user being able to enter formatting characters (fixes #2892) #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -712,6 +712,10 @@ void platform_process_messages() | |||
| if (e.text.text[0] == '`' && gConsoleOpen) | |||
| break; | |||
|
|
|||
| // Entering formatting characters is not allowed | |||
| if (utf8_is_format_code((int)e.text.text[0])) | |||
There was a problem hiding this comment.
This is not handling UTF-8 correctly, you need to use utf8_get_next.
There was a problem hiding this comment.
Should line 712 stay the way it is?
There was a problem hiding this comment.
Yea, UTF-8 is backwards compatible with ASCII, its only because some format codes are not ASCII that we need to do this.
IntelOrca
added a commit
that referenced
this pull request
Feb 11, 2016
Fix user being able to enter formatting characters (fixes #2892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original game silently removes these characters after entering them. It seems more appropriate for OpenRCT2 to simply not accept entering them.