Fix #8584: Duck spawn search now uses entire map #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanspumpkin
previously requested changes
Aug 19, 2019
|
If this gets rebased and changed to use coords which might be easier now after @duncanspumpkin's refactor, we can merge. |
|
Sorry got a little distracted by other things, will do this today. |
|
Applied the requested changes and cleaned up the code a little bit. Also I bumped up the network version since scenario_rand is now called twice. |
ZehMatt
added
changelog
|
Could you rebase this and rebump the network version? I think it's time to get this merged, and Duncan's requested changes have been made anyway. |
ZehMatt
force-pushed
the
fix-8584
branch
3 times, most recently
from
e7c7dce
to
03ecfb7
Compare
|
Rebased and incremented the network version |
Gymnasiast
reviewed
Oct 2, 2019
Gymnasiast
dismissed
duncanspumpkin’s stale review
Requested changes have been made
Gymnasiast
approved these changes
Oct 2, 2019
XplosiveLugnut
pushed a commit
to XplosiveLugnut/OpenRCT2
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should be without crashes. I left a few asserts in there to be sure and they have no performance impact.