Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ".Wcf" to Hosting assembly name and namespaces #251

Merged
merged 19 commits into from
Nov 13, 2020
Merged

Add ".Wcf" to Hosting assembly name and namespaces #251

merged 19 commits into from
Nov 13, 2020

Conversation

Daniel-Svensson
Copy link
Member

@Daniel-Svensson Daniel-Svensson commented Nov 11, 2020 •
edited
Loading

Part of #244

  • Update changelog with required changes to .config file
  • Change WCF to 'Wcf'
  • Rename project folders so that they have the same name as the projects

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 11, 2020

This pull request introduces 1 alert and fixes 1 when merging f744ad2 into e94f4b5 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

fixed alerts:

  • 1 for Missing Dispose call on local IDisposable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 11, 2020

This pull request introduces 1 alert and fixes 2 when merging 678ca2a into e94f4b5 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

fixed alerts:

  • 1 for Dereferenced variable may be null
  • 1 for Missing Dispose call on local IDisposable

@Daniel-Svensson Daniel-Svensson marked this pull request as ready for review November 11, 2020 13:07
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 11, 2020

This pull request introduces 1 alert and fixes 2 when merging 3647727 into e94f4b5 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

fixed alerts:

  • 1 for Dereferenced variable may be null
  • 1 for Missing Dispose call on local IDisposable

@Daniel-Svensson
Fix test errors
22ccb37 
* Add missing using to baseline
* Update configuration in app.config
* Fix resource file namespace
@Daniel-Svensson
Split out hosting assembly to separate nuget
758cd2c
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 11, 2020

This pull request introduces 1 alert and fixes 2 when merging 22ccb37 into e94f4b5 - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

fixed alerts:

  • 1 for Dereferenced variable may be null
  • 1 for Missing Dispose call on local IDisposable

@Daniel-Svensson
Copy link
Member Author

Daniel-Svensson commented Nov 11, 2020 •
edited
Loading

I think I want to change casing of WCF with "Wcf' and update the folder names to match the new project names before completing this.

Follow Framework Design Guidelines and use "Wcf" for types and namespaces.

@Daniel-Svensson
Expose internal types from Server project to Hosting project to preve…
00a4d63 
…nt compiling several types in many projects.

* Static caches such as the one for MetaType will now be shared between assemblies
* Should result in slightly smaller binaries and smaller memory footprint
@Daniel-Svensson
remove acciddentally added file
bdd7a91
@Daniel-Svensson Daniel-Svensson changed the title WIP: Add ".Wcf" to Hosting assembly name and namespaces Add ".Wcf" to Hosting assembly name and namespaces Nov 12, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 12, 2020

This pull request introduces 1 alert and fixes 1 when merging f36d8aa into ebb8dfa - view on LGTM.com

new alerts:

  • 1 for Missing Dispose call on local IDisposable

fixed alerts:

  • 1 for Missing Dispose call on local IDisposable

@Daniel-Svensson Daniel-Svensson added this to the 5.0 milestone Nov 13, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 13, 2020

This pull request introduces 15 alerts and fixes 2 when merging 1f0872a into ebb8dfa - view on LGTM.com

new alerts:

  • 14 for Dereferenced variable may be null
  • 1 for Missing Dispose call on local IDisposable

fixed alerts:

  • 1 for Dereferenced variable may be null
  • 1 for Missing Dispose call on local IDisposable

@sonarcloud
Copy link

sonarcloud bot commented Nov 13, 2020

SonarCloud Quality Gate failed.

Bug D 4 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 175 Code Smells

0.0% 0.0% Coverage
1.7% 1.7% Duplication

@Daniel-Svensson Daniel-Svensson merged commit 5a91d68 into OpenRIAServices:main Nov 13, 2020
@Daniel-Svensson Daniel-Svensson deleted the feature/hosting_rename branch November 13, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklas-holma niklas-holma niklas-holma approved these changes

Assignees
No one assigned
Labels
Area-Server Breaking Change
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-Svensson @niklas-holma