Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor : Created objects disappear, Deleted objects are still visible, and Zoom brings strange behaviors #3323

Closed
Tguisnet opened this issue Feb 23, 2023 · 1 comment
Closed

Editor : Created objects disappear, Deleted objects are still visible, and Zoom brings strange behaviors #3323

Tguisnet opened this issue Feb 23, 2023 · 1 comment
Assignees
@jacomyal
Labels
kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug

Comments

@Tguisnet
Copy link
Contributor

Tguisnet commented Feb 23, 2023 •
edited
Loading

What happened?

When we create an object, sometimes, it disappears.
This applies to buffer stop, detector, switch, tracks, ...

When we try to delete an object, it is still visible on the map.
This applies to buffer stop, detector, switch, tracks, ...

All of this behaviours could depend on the zooming level.
(at a certain zooming level, all the infra disappear)

bug.zoom.mp4

What did you expect to happen?

The object should be visible when it is created.
The object should disappear when it is deleted.

We could see all our infra at any zooming level.

How can we reproduce it (as minimally and precisely as possible)?

  1. Go on the editor
  2. Create objects
  3. Delete objects
  4. Zoom/Dezoom

What operating system, browser and environment are you using?

  • Browser: Chrome v110
  • OS: Windows 10
  • Env: Dgex dev

OSRD version (top right corner Account button > Informations)

22a23a4
@Tguisnet Tguisnet added kind:bug Something isn't working severity:major Major severity bug labels Feb 23, 2023
@Tguisnet Tguisnet changed the title Editor : Deleted objects are still visible on the map Editor : Zoom brings strange behavior (Created objects disappear, Deleted objects are still visible, ...) Feb 23, 2023
@Tguisnet Tguisnet added severity:critical Critical severity bug and removed severity:major Major severity bug labels Feb 23, 2023
@Tguisnet Tguisnet changed the title Editor : Zoom brings strange behavior (Created objects disappear, Deleted objects are still visible, ...) Editor : Created objects disappear, Deleted objects are still visible, and Zoom brings strange behavior Feb 23, 2023
@Tguisnet Tguisnet changed the title Editor : Created objects disappear, Deleted objects are still visible, and Zoom brings strange behavior Editor : Created objects disappear, Deleted objects are still visible, and Zoom brings strange behaviors Feb 23, 2023
@flomonster flomonster added the module:infra-editor Infra Edition label Mar 2, 2023
jacomyal added a commit that referenced this issue Mar 10, 2023
@jacomyal
editor: forces reloading tiles after deleting data
fe498ed 
This commit should partially solve issue #3323.
However, there appear to be some issue backend side, that could still
make the item reappear in some tiles. This is being investigated.

Details:
- Adds a fingerprint in the editor context, and a method to force
regenerating this fingerprint
- Propagates the fingerprint to the GeoJSONs module
- Remounts sources in GeoJSONs on fingerprint updates
@jacomyal jacomyal mentioned this issue Mar 10, 2023
Closed
@flomonster flomonster mentioned this issue Mar 10, 2023
Closed
jacomyal added a commit that referenced this issue Mar 10, 2023
@jacomyal
editor: forces reloading tiles after deleting data
88aeee9 
This commit should partially solve issue #3323.
However, there appear to be some issue backend side, that could still
make the item reappear in some tiles. This is being investigated.

Details:
- Adds a fingerprint in the editor context, and a method to force
regenerating this fingerprint
- Propagates the fingerprint to the GeoJSONs module
- Remounts sources in GeoJSONs on fingerprint updates
@jacomyal jacomyal mentioned this issue Mar 10, 2023
Merged
sim51 pushed a commit that referenced this issue Mar 10, 2023
@jacomyal @sim51
editor: forces reloading tiles after deleting data
55bb5a9 
This commit should partially solve issue #3323.
However, there appear to be some issue backend side, that could still
make the item reappear in some tiles. This is being investigated.

Details:
- Adds a fingerprint in the editor context, and a method to force
regenerating this fingerprint
- Propagates the fingerprint to the GeoJSONs module
- Remounts sources in GeoJSONs on fingerprint updates
@jacomyal
Copy link
Contributor

@Tguisnet I can't reproduce the issue locally, now that PRs #3485 and #3492 have been merged. Do you confirm it does not occur anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacomyal jacomyal

Labels
kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacomyal @flomonster @Tguisnet