editor: forces reloading tiles after deleting data (related to #3323) #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should partially solve issue #3323. However, there appear to be some issue backend side, that could still make the item reappear in some tiles. This is being investigated. Details: - Adds a fingerprint in the editor context, and a method to force regenerating this fingerprint - Propagates the fingerprint to the GeoJSONs module - Remounts sources in GeoJSONs on fingerprint updates
Codecov Report
@@ Coverage Diff @@
## dev #3492 +/- ##
============================================
- Coverage 67.90% 67.88% -0.02%
Complexity 1883 1883
============================================
Files 405 405
Lines 20077 20087 +10
Branches 1501 1501
============================================
+ Hits 13633 13636 +3
- Misses 5760 5767 +7
Partials 684 684
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sim51
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editor: forces reloading tiles after deleting data
This commit should partially solve issue #3323.
However, there appear to be some issue backend side, that could still make the item reappear in some tiles. This is being investigated.
Details: