Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: front: Replace chartos routes by editoast's layers/ #3020

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Jan 27, 2023

This PR is :

  • Adding rust logic to build mvt tiles in editoast
  • Chartos is no longer used by the front
    • Will be dropped in a following PR (remove code, change docker compose, rename remaining chartos in the code...)
  • Removing chartos from the front

close #2893
close #2895

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3020 (aeda4f7) into dev (c1c3796) will decrease coverage by 0.10%.
The diff coverage is 21.05%.

@@             Coverage Diff              @@
##                dev    #3020      +/-   ##
============================================
- Coverage     38.99%   38.90%   -0.10%     
  Complexity     1705     1705              
============================================
  Files           606      606              
  Lines         18528    18622      +94     
  Branches       2497     2496       -1     
============================================
+ Hits           7225     7244      +19     
- Misses        10893    10968      +75     
  Partials        410      410              
Flag Coverage Δ
editoast 70.64% <20.90%> (-2.41%) ⬇️
front 4.82% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/chartos/mod.rs 31.42% <ø> (ø)
editoast/src/schema/geo_json.rs 0.00% <0.00%> (ø)
editoast/src/schema/mod.rs 79.62% <ø> (ø)
front/src/common/api/emptyApi.ts 57.14% <ø> (-9.53%) ⬇️
front/src/common/api/osrdEditoastApi.ts 0.00% <0.00%> (ø)
front/src/common/requests.ts 0.00% <0.00%> (ø)
front/src/config/config.js 100.00% <ø> (ø)
editoast/src/views/layers/layer.rs 33.33% <3.22%> (-40.58%) ⬇️
editoast/src/views/layers/mvt_utils.rs 18.33% <18.33%> (ø)
editoast/src/chartos/redis_utils.rs 91.30% <81.81%> (-8.70%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou force-pushed the brieuc/MvtTile branch 2 times, most recently from 0048213 to 17c0c68 Compare January 30, 2023 11:00
@bloussou bloussou added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service labels Jan 30, 2023
@bloussou bloussou changed the title Replace chartos routes by editoast's layers/ editoast: front: Replace chartos routes by editoast's layers/ Jan 30, 2023
@bloussou bloussou marked this pull request as ready for review January 30, 2023 11:13
@bloussou bloussou requested review from a team, flomonster and multun as code owners January 30, 2023 11:13
editoast/src/views/layers/geo_json.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/mvt_utils.rs Show resolved Hide resolved
editoast/src/views/layers/mvt_utils.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/mvt_utils.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/mvt_utils.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/geo_json.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few details needs to be fixed. I can't make it work (I got no data in the responses).

editoast/src/chartos/redis_utils.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/geo_json.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/geo_json.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/geo_json.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
@bloussou bloussou force-pushed the brieuc/MvtTile branch 2 times, most recently from d3c1549 to 2232185 Compare January 31, 2023 14:40
flomonster
flomonster previously approved these changes Jan 31, 2023
@flomonster flomonster merged commit 392e39f into dev Jan 31, 2023
@flomonster flomonster deleted the brieuc/MvtTile branch January 31, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate possibility of mvt tiles generation using rust Move chartos mvt_view_tile() to editoast
3 participants