Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chartos: front: editoast: Drop chartos #3035

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Jan 30, 2023

follow up of #3020

This PR is :

  • removing chartos code from the repository
  • renaming editoast's chartos/ folder in map/
  • Removing front part relying on chartos version since there is no need to display it anymore

close #1795

@bloussou bloussou self-assigned this Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3035 (92fd969) into dev (a6d152c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3035   +/-   ##
=========================================
  Coverage     38.62%   38.62%           
  Complexity     1705     1705           
=========================================
  Files           605      605           
  Lines         18762    18757    -5     
  Branches       2513     2513           
=========================================
- Hits           7246     7245    -1     
+ Misses        11106    11102    -4     
  Partials        410      410           
Flag Coverage Δ
editoast 70.68% <ø> (-0.05%) ⬇️
front 4.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/infra.rs 66.66% <ø> (ø)
editoast/src/infra_cache/mod.rs 69.30% <ø> (ø)
editoast/src/main.rs 31.25% <ø> (ø)
editoast/src/map/bounding_box.rs 20.40% <ø> (ø)
editoast/src/map/layer_cache.rs 100.00% <ø> (ø)
editoast/src/map/map_layers.rs 100.00% <ø> (ø)
editoast/src/map/mod.rs 31.42% <ø> (ø)
editoast/src/map/redis_utils.rs 91.30% <ø> (ø)
editoast/src/schema/track_section.rs 83.87% <ø> (ø)
editoast/src/views/infra/edition.rs 96.87% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou force-pushed the brieuc/MvtTile branch 4 times, most recently from 2232185 to aeda4f7 Compare January 31, 2023 15:44
Base automatically changed from brieuc/MvtTile to dev January 31, 2023 16:58
@bloussou bloussou changed the title chartos: Drop chartos chartos: front: editoast: Drop chartos Feb 1, 2023
@bloussou bloussou marked this pull request as ready for review February 1, 2023 10:22
@bloussou bloussou requested review from a team, flomonster and multun as code owners February 1, 2023 10:22
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Well done. We still have some occurrence of chartis in the front. We can handle this later.

@flomonster flomonster merged commit 214da07 into dev Feb 1, 2023
@flomonster flomonster deleted the brieuc/DropChartos branch February 1, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port chartos to rust and merge it with osrd-webservice
3 participants