-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: front: uses editoast endpoints instead of api endpoints for study and scenarios #3699
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3699 +/- ##
============================================
- Coverage 68.88% 68.88% -0.01%
Complexity 2002 2002
============================================
Files 439 439
Lines 22346 22349 +3
Branches 1658 1658
============================================
+ Hits 15394 15396 +2
- Misses 6157 6158 +1
Partials 795 795
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d4a9c6c
to
ddadd40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the integration test test_scenario.py
? And adapt fixtures in conftest.py
to use editoast endpoints ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your PR!
ddadd40
to
68bb1b6
Compare
a985d09
to
8e42ad2
Compare
8e42ad2
to
66c653f
Compare
… study and scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some print to remove in tests otherwise test part looks ok ✔️
66c653f
to
e6f69cd
Compare
e6f69cd
to
0aa7e0f
Compare
0aa7e0f
to
35142f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉 Is there a plan to move to rtk endpoint after this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
Close #3698
As we modify a lot of endpoints (all the endpoints related to project, scenario and study), we do not migrate them to RTK to avoid breaking the app. The migration will be done in following PRs.