Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: front: uses editoast endpoints instead of api endpoints for study and scenarios #3699

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Mar 27, 2023

Close #3698

As we modify a lot of endpoints (all the endpoints related to project, scenario and study), we do not migrate them to RTK to avoid breaking the app. The migration will be done in following PRs.

@younesschrifi younesschrifi requested review from a team as code owners March 27, 2023 14:05
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #3699 (35142f9) into dev (8829ac7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #3699      +/-   ##
============================================
- Coverage     68.88%   68.88%   -0.01%     
  Complexity     2002     2002              
============================================
  Files           439      439              
  Lines         22346    22349       +3     
  Branches       1658     1658              
============================================
+ Hits          15394    15396       +2     
- Misses         6157     6158       +1     
  Partials        795      795              
Flag Coverage Δ
editoast 75.28% <100.00%> (-0.03%) ⬇️
front 57.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/models/study.rs 93.33% <ø> (ø)
editoast/src/tables.rs 0.00% <ø> (ø)
editoast/src/models/scenario.rs 75.75% <100.00%> (ø)
editoast/src/views/scenario.rs 95.29% <100.00%> (ø)
editoast/src/views/study.rs 91.86% <100.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 90.98% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the integration test test_scenario.py ? And adapt fixtures in conftest.py to use editoast endpoints ?

flomonster
flomonster previously approved these changes Mar 30, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your PR!

eckter
eckter previously approved these changes Mar 30, 2023
bloussou
bloussou previously approved these changes Apr 3, 2023
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some print to remove in tests otherwise test part looks ok ✔️

tests/conftest.py Outdated Show resolved Hide resolved
tests/tests/test_scenario.py Outdated Show resolved Hide resolved
anisometropie
anisometropie previously approved these changes Apr 3, 2023
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 Is there a plan to move to rtk endpoint after this PR ?

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@bloussou bloussou requested a review from eckter April 3, 2023 16:35
@younesschrifi younesschrifi merged commit 76f95fe into dev Apr 4, 2023
@younesschrifi younesschrifi deleted the yci/replace-api-endpoints branch April 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: front: replace study and scenario api endpoints by editoast endpoints
6 participants