Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: tests: make e2e tests work when running on a dirty env #3782

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Apr 3, 2023

Thanks to this PR e2e tests can be run without having to start from an empty database.

Top be merged after #3699 for conflict reason

close #3778

@bloussou bloussou requested review from eckter and a team as code owners April 3, 2023 14:51
@bloussou bloussou added area:front Work on Standard OSRD Interface modules kind:tests Writing unit / e2e and integration tests labels Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #3782 (c12f8e1) into dev (76f95fe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3782   +/-   ##
=========================================
  Coverage     69.80%   69.80%           
  Complexity     2002     2002           
=========================================
  Files           438      438           
  Lines         21899    21899           
  Branches       1658     1658           
=========================================
  Hits          15286    15286           
  Misses         5818     5818           
  Partials        795      795           
Flag Coverage Δ
front 59.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou force-pushed the brieuc/E2EWithExplicitSelection branch from d62f706 to f075d21 Compare April 3, 2023 15:03
@bloussou bloussou force-pushed the brieuc/E2EWithExplicitSelection branch from f075d21 to c12f8e1 Compare April 4, 2023 07:48
@bloussou bloussou requested a review from clarani April 4, 2023 07:48
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@bloussou bloussou merged commit 54becc9 into dev Apr 4, 2023
@bloussou bloussou deleted the brieuc/E2EWithExplicitSelection branch April 4, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:tests Writing unit / e2e and integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: front: Make e2e tests work on a database with already existing projects
3 participants