editor: fixes #3904 and #3906 #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - Writes a new component dedicated to handle speed editions in km/h, while the value is stored as m/s - Handles weird behaviours by only updating the local component state when the related number m/s value changes - Uses this new component for both speed_limit and speed_limit_by_tag edition
sim51
approved these changes
Apr 14, 2023
Codecov Report
@@ Coverage Diff @@
## dev #3911 +/- ##
=========================================
Coverage 69.67% 69.67%
Complexity 2026 2026
=========================================
Files 439 439
Lines 22242 22242
Branches 1672 1672
=========================================
Hits 15498 15498
Misses 5939 5939
Partials 805 805
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: