Project import vulnerable to arbitrary file write

[itsacoderepo]

Describe the bug
The import of a project is prone to a path traversal and thus an arbitrary file write.

To Reproduce
Steps to reproduce the behavior:

1. Download payload.txt
2. gzip payload.txt, payload.txt.gz is greated
3. Go to OpenRefine, Import Projects
4. Choose payload.txt.gz
5. Import file
6. cat /tmp/ohno should show the content of the file.

Current Results
The first 100 bytes are from the file payload.txt are chosen as path, not the filename itself. An error is also shown but is not related to the path traversal.

Expected behavior
Show an error, warn user, do not write file outside of the project folder.

Video
project_import_vuln.zip

Desktop (please complete the following information):
Not important

OpenRefine (please complete the following information):

• Demo with 3.1 but should work with master

Datasets
Payload file
https://github.com/OpenRefine/OpenRefine/files/2721399/payload.txt

Additional context
Please also update dependencies. The ant library is out of date and sloppy (compared to other) handling (tar) archive header.

If you have questions, you can reach me at "niko at-sign shiftleft.io" or https://twitter.com/0x4d5a.

[nluedtke]

This was assigned CVE-2019-3580.

[wetneb]

@itsacoderepo I think your instructions to reproduce the vulnerability are missing one step: rename payload.txt.gz to payload.tar.gz.

But even with that fix I cannot reproduce this - as far as I can tell this was fixed by #1901. So closing as non reproducible in a few days unless I missed something.

[wetneb]

Closing as non reproducible.