Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clustering dialog does not show duplicate whitespace clearly #4004

Closed
wetneb opened this issue Jun 22, 2021 · 0 comments · Fixed by #4005
Closed

Clustering dialog does not show duplicate whitespace clearly #4004

wetneb opened this issue Jun 22, 2021 · 0 comments · Fixed by #4005
Assignees
@wetneb
Labels
clustering Issues related to the clustering operation, to merge similar values in a text column Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.5

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Jun 22, 2021

When clustering values which contain duplicate whitespace characters, these characters are not clearly shown in the clustering dialog, giving the impression that we are clustering identical values.

To Reproduce

Steps to reproduce the behavior:

  1. First, import the following file (as a lines-based or CSV file for instance):
foo
b ar
b  ar
b   ar
  1. Then, open the clustering dialog on that column.

Current Results

All options look the same:
image

Expected Behavior

Space differences should be respected:
image

Versions

  • Operating System: Linux
  • Browser Version: Firefox 78
  • JRE or JDK Version: 11
  • OpenRefine: 3.5 beta1
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. clustering Issues related to the clustering operation, to merge similar values in a text column labels Jun 22, 2021
@wetneb wetneb self-assigned this Jun 22, 2021
wetneb added a commit to wetneb/OpenRefine that referenced this issue Jun 22, 2021
@wetneb
Respect spaces in clustering dialog. Closes OpenRefine#4004.
f1241c8
@wetneb wetneb mentioned this issue Jun 22, 2021
Merged
wetneb added a commit that referenced this issue Jun 27, 2021
@wetneb
Respect spaces in clustering dialog. Closes #4004. (#4005)
9919ee5
@wetneb wetneb added this to the 3.5 milestone Jun 27, 2021
wetneb added a commit that referenced this issue Jun 27, 2021
@wetneb
Respect spaces in clustering dialog. Closes #4004. (#4005)
c49e7a4
wetneb added a commit that referenced this issue Jun 29, 2021
@wetneb
Respect spaces in clustering dialog. Closes #4004. (#4005)
cf338a9
This was referenced Jul 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
clustering Issues related to the clustering operation, to merge similar values in a text column Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Respect spaces in clustering dialog. wetneb/OpenRefine
1 participant
@wetneb