Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory setting on Linux CLI is broken #4265

Closed
wetneb opened this issue Nov 4, 2021 · 0 comments · Fixed by #4266
Closed

Memory setting on Linux CLI is broken #4265

wetneb opened this issue Nov 4, 2021 · 0 comments · Fixed by #4266
Assignees
@wetneb
Labels
Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.5

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Nov 4, 2021

The parameter to define the memory used by OpenRefine is broken in the ./refine script that we use on Linux.

To Reproduce

Steps to reproduce the behavior:

  1. Run ./refine -m 2048M

Current Results

./refine: line 852: [: 2048M: integer expression expected

Expected Behavior

No error, the memory settings are properly set.

Versions

  • Operating System: Debian
  • Browser Version: Irrelevant
  • JRE or JDK Version: 11
  • OpenRefine: 3.5-beta2

Additional context

Brought up here: https://groups.google.com/g/openrefine/c/2nfrI8eteCU
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Nov 4, 2021
@wetneb wetneb self-assigned this Nov 4, 2021
@wetneb wetneb added this to the 3.5 milestone Nov 4, 2021
wetneb added a commit that referenced this issue Nov 4, 2021
@wetneb
Let -m (UNIX) and /m (Windows) options control initial heap size too.
17b1ee2 
If we only let them control the max heap size then we can run into
issues when our initial heap size is higher than the maximum one.

Better fix for #388.
Closes #4265.
@wetneb wetneb mentioned this issue Nov 4, 2021
Merged
wetneb added a commit that referenced this issue Nov 4, 2021
@wetneb
Let the -m (UNIX) and /m (Windows) options steer both the min and max…
e650be6 
… memory settings.

This is a more reliable fix for #388 (#2490).

Closes #4265.
wetneb added a commit that referenced this issue Nov 7, 2021
@wetneb
Fix CLI setting for memory size (-m and /m) (#4266)
64f072c 
* Let the -m (UNIX) and /m (Windows) options steer both the min and max memory settings.

This is a more reliable fix for #388 (#2490).

Closes #4265.

* Do the same on Windows
wetneb added a commit that referenced this issue Nov 7, 2021
@wetneb
Fix CLI setting for memory size (-m and /m) (#4266)
41c7b70 
* Let the -m (UNIX) and /m (Windows) options steer both the min and max memory settings.

This is a more reliable fix for #388 (#2490).

Closes #4265.

* Do the same on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Fix CLI setting for memory size (-m and /m) OpenRefine/OpenRefine
1 participant
@wetneb