Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store file source in each row not working for JSON from URL #512

Closed
tfmorris opened this issue Oct 15, 2012 · 1 comment
Closed

Store file source in each row not working for JSON from URL #512

tfmorris opened this issue Oct 15, 2012 · 1 comment
Assignees
@jackyq2015
Labels
imported from old code repo Issue imported from Google Code in 2010 Priority: Medium Represents important issues that need to be addressed but are not urgent Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
2.6

Comments

@tfmorris
Copy link
Member

tfmorris commented Oct 15, 2012 •
edited by thadguidry

Original author: thadguidry (December 27, 2011 04:17:14)

What steps will reproduce the problem?

  1. Point to a JSON file url.
  2. Create a Refine Project and preview with JSON importer.
  3. Check the box to Store file source in each row.
  4. Preview shows nothing changed.
  5. Create Project.

Project shows no extra column created for file source or source URL of the JSON file.

Original issue: http://code.google.com/p/google-refine/issues/detail?id=512
@tfmorris
Copy link
Member Author

From tfmorris on December 27, 2011 20:57:39:
From a quick glance at the code, it would appear that this option is only implemented for tabular importers, not tree (ie XML & JSON) importers.

@jackyq2015 jackyq2015 mentioned this issue Aug 5, 2015
Closed
@jackyq2015 jackyq2015 self-assigned this Aug 19, 2015
jackyq2015 pushed a commit to RefinePro/OpenRefine that referenced this issue Aug 25, 2015
fix issue OpenRefine#512 to store the file source
c3b4183
jackyq2015 pushed a commit to RefinePro/OpenRefine that referenced this issue Aug 27, 2015
fix issue OpenRefine#512 to save the file location as a table column
4e6f584
@magdmartin magdmartin mentioned this issue Sep 20, 2015
Merged
magdmartin added a commit that referenced this issue Sep 20, 2015
@magdmartin
Merge pull request #1055 from RefinePro/issue-512
b635f4e 
fix issue #512 to save the file location as a table column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackyq2015 jackyq2015

Labels
imported from old code repo Issue imported from Google Code in 2010 Priority: Medium Represents important issues that need to be addressed but are not urgent Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
3 participants
@tfmorris @magdmartin @jackyq2015