fix issue #512 to save the file location as a table column #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix for #512 |
magdmartin
added a commit
that referenced
this pull request
Sep 20, 2015
fix issue #512 to save the file location as a table column
| } | ||
|
|
||
| public ImportParameters(boolean trimStrings, boolean storeEmptyStrings, boolean guessCellValueTypes) { | ||
| this.trimStrings = trimStrings; |
There was a problem hiding this comment.
This should call the constructor above (Line 11) rather than duplicating code.
There was a problem hiding this comment.
Agree, do you want me to commit the change or create another branch from the fork?
tfmorris
added
the
Status: Pending Review
tfmorris
pushed a commit
to tfmorris/OpenRefine
that referenced
this pull request
Sep 25, 2015
|
I've incorporated fixes for most of these comments in be936a8. I'll discuss with @magdmartin who he had review the changes before he agreed to commit the PR to see if we can improve the process. |
tfmorris
removed
the
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.