Fix reconciliation dialog overflow issue. #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to redesign this dialog completely - there are a lot of issues with it. This is just a fairly minimal fix to avoid its contents overflowing and hiding the "Reconcile" and "Cancel" buttons. Closes OpenRefine#5285.
github-actions
bot
added
Type: Bug
elebitzero
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Looks good, except without width: 500px, when the reconcile dialog first opens the main panel is empty until you select a recon service, and it looks odd with the service dropdown menu extended outside the dialog, as seen below. I would change it to min-width: 500px.
(Only need to set min-width on recon-dialog-service-panel-container, not necessary for recon-dialog-service)
I noted on the issue that this is not a regression, but has been existing bug. If we will have a 3.6.2 patch, this is a good candidate.
|
Thanks a lot, I should have caught that… |
wetneb
added a commit
that referenced
this pull request
Oct 3, 2022
* Fix recon dialog overflow issue. We plan to redesign this dialog completely - there are a lot of issues with it. This is just a fairly minimal fix to avoid its contents overflowing and hiding the "Reconcile" and "Cancel" buttons. Closes #5285. * Add min-height to fix service selection issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to redesign this dialog completely - there are a lot of issues with it. This is just a fairly minimal fix to avoid its contents overflowing and hiding the "Reconcile" and "Cancel" buttons.
Closes #5285.
Changes proposed in this pull request:
height: 500pxset on the dialog so that it can expand further down to fit its contentsNew version: