Checking running status of OpenRefine with wget will not work correctly

[ostephens]

The PR #6361 which was meant to fix #2000 changes the check_running() code in the refine script. It introduces a variable URL_LOCAL="http://127.0.0.1" alongside the existing variable URL="http://${REFINE_HOST_INTERNAL}:${REFINE_PORT}/".

• if cURL is used to check for a running OpenRefine instance, it checks using the URL variable
• if wget is used to check for a running OpenRefine instance, it checks using the URL_LOCAL variable

This means wget will never fetch the OpenRefine page because it doesn't use the specified host or port that OpenRefine is/should be expected to be running on.

I believe that the lines for wget

OpenRefine/refine

Line 106 in 24947a3

no_proxy=127.0.0.1 wget -O - $URL_LOCAL > /dev/null 2>&1

OpenRefine/refine

Line 116 in 24947a3

RUNNING=`no_proxy=127.0.0.1 wget -O - $URL_LOCAL | grep "$CHECK_STR"`

should check the URL not URL_LOCAL and URL_LOCAL variable can be removed as it is redundant