Avoid going through HTTP proxy for requests to localhost in refine script #6361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
requested changes
Feb 13, 2024
Closed
|
Yes Sure. I made similar changes for wget please review. |
wetneb
reviewed
Feb 14, 2024
refine
Outdated
| CURL_RETURN=$? | ||
| if [ $CURL_RETURN -eq "7" ] || [ $CURL_RETURN -eq "22" ] ; then | ||
| NOT_RUNNING="1" | ||
| fi | ||
| elif [ "$WGET" ] ; then | ||
| wget -O - $URL > /dev/null 2>&1 | ||
| wget --noproxy 127.0.0.1 -O - $URL > /dev/null 2>&1 |
There was a problem hiding this comment.
No, the same syntax does not work for wget, as --noproxy is not a valid wget option.
wetneb
reviewed
Feb 14, 2024
refine
Outdated
| CURL_RETURN=$? | ||
| if [ $CURL_RETURN -eq "7" ] || [ $CURL_RETURN -eq "22" ] ; then | ||
| NOT_RUNNING="1" | ||
| fi | ||
| elif [ "$WGET" ] ; then | ||
| wget -O - $URL > /dev/null 2>&1 | ||
| wget --no-proxy -q -O - $URL_LOCAL > /dev/null 2>&1 |
There was a problem hiding this comment.
Suggested change
| wget --no-proxy -q -O - $URL_LOCAL > /dev/null 2>&1 | |
| no_proxy=127.0.0.1 wget -O - $URL_LOCAL > /dev/null 2>&1 |
refine
Outdated
| elif [ "$WGET" ] ; then | ||
| RUNNING=`wget -q -O - $URL | grep "$CHECK_STR"` | ||
| RUNNING=`wget --no-proxy -q -O - $URL_LOCAL | grep "$CHECK_STR"` |
There was a problem hiding this comment.
Suggested change
| RUNNING=`wget --no-proxy -q -O - $URL_LOCAL | grep "$CHECK_STR"` | |
| RUNNING=`no_proxy=127.0.0.1 wget -O - $URL_LOCAL | grep "$CHECK_STR"` |
|
@wetneb I made the suggested changes, please let me know if I need to follow any steps since this is my first open-source contribution. |
github-actions
bot
added
Type: Bug
wetneb
changed the title
This was referenced May 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2000