Make it possible to link to a given home screen panel #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abbe98
force-pushed
the
home-panel-linking
branch
from
33dca23
to
602984b
Compare
elebitzero
approved these changes
Feb 3, 2023
@elebitzero I'm not sure, it gets tricky especially if one would like to deal with things like focus management (which I would like to follow up with). |
Abbe98
added a commit
to Abbe98/OpenRefine
that referenced
this pull request
Apr 3, 2023
The ability to filter projects by tags used URL-hashes for managing state, this, however interferes with the home screen panel links introduced in OpenRefine#5597. This change therefor, moves the filtering state to query params. Side effects: - you can now link to an tag filter - fixed some bugs caused by naming a tag "all"
Abbe98
added a commit
to Abbe98/OpenRefine
that referenced
this pull request
Apr 4, 2023
The ability to filter projects by tags uses URL-hashes for managing state, this, however interferes with the home screen panel links introduced in OpenRefine#5597. This change therefor, moves the filtering state to query params. Side effects: - you can now link to a tag filter - fixed some bugs caused by naming a tag "all" - ensured that OpenRefine's URL utility does not overwrite the native URL class.
Abbe98
added a commit
to Abbe98/OpenRefine
that referenced
this pull request
Apr 4, 2023
The ability to filter projects by tags uses URL-hashes for managing state, this, however interferes with the home screen panel links introduced in OpenRefine#5597. This change therefor, moves the filtering state to query params. Side effects: - you can now link to a tag filter - fixed some bugs caused by naming a tag "all" - ensured that OpenRefine's URL utility does not overwrite the native URL class.
Abbe98
added a commit
to Abbe98/OpenRefine
that referenced
this pull request
May 31, 2023
The ability to filter projects by tags uses URL-hashes for managing state, this, however interferes with the home screen panel links introduced in OpenRefine#5597. This change therefor, moves the filtering state to query params. Side effects: - you can now link to a tag filter - fixed some bugs caused by naming a tag "all" - ensured that OpenRefine's URL utility does not overwrite the native URL class.
Abbe98
added a commit
that referenced
this pull request
Jun 7, 2023
) The ability to filter projects by tags uses URL-hashes for managing state, this, however interferes with the home screen panel links introduced in #5597. This change therefor, moves the filtering state to query params. Side effects: - you can now link to a tag filter - fixed some bugs caused by naming a tag "all" - ensured that OpenRefine's URL utility does not overwrite the native URL class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to link to given panel by its identifier.
To for example go straight to the language settings one could navigate to:
http://127.0.0.1:3333/#lang-settings