open project: move tag filter state from URL hash to query params #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abbe98
force-pushed
the
open-project-tags
branch
2 times, most recently
from
991e1b1
to
b19e71e
Compare
elebitzero
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Looks good, except on refresh the selected tag is not restored:
http://127.0.0.1:3333/?tag=foo#open-project
should select 'foo' and filter the projects with foo tag.
http://127.0.0.1:3333/?tag=#open-project
should select 'All' and show all projects.
|
@Abbe98 quick reminder about this - It looks like a good move to me so it's probably worth addressing @elebitzero's comments to avoid the PR getting stale? |
It's on my radar and I have a solution in mind. |
The ability to filter projects by tags uses URL-hashes for managing state, this, however interferes with the home screen panel links introduced in OpenRefine#5597. This change therefor, moves the filtering state to query params. Side effects: - you can now link to a tag filter - fixed some bugs caused by naming a tag "all" - ensured that OpenRefine's URL utility does not overwrite the native URL class.
elebitzero
approved these changes
Jun 7, 2023
|
The changes look good, OR now keeps the selected tag on refresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to filter projects by tags uses URL-hashes for managing state, this, however interferes with the home screen panel links introduced in #5597. This change therefor, moves the filtering state to query params.
Side effects: