Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Velocity from 1.5 to 2.3. Fixes #4078 / CVE-2020-13936 #6190

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

tfmorris
Copy link
Member

Fixes #4078. Resolves CVE-2020-13936

Changes proposed in this pull request:

Set properties for maximum 1.x compatibility per version upgrade notes
https://velocity.apache.org/engine/2.0/upgrading.html
@github-actions github-actions bot added the vulnerability Security vulnerability which needs fixing label Nov 26, 2023
Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wetneb wetneb merged commit 0945595 into OpenRefine:master Nov 27, 2023
12 checks passed
@tfmorris tfmorris deleted the 4078-velocity-vulnerability branch December 14, 2023 02:20
@wetneb
Copy link
Sponsor Member

wetneb commented May 23, 2024

@tfmorris it seems that this is causing incompatibility problems for extensions, see #6581

@thadguidry
Copy link
Member

@wetneb maybe we just need to check the new dependency requirements below? Because @tfmorris forgot about them, or missed that part...

He did this...

For busy people: To maximize backward compatibility with Velocity 1.x, be sure to include the following lines in your Velocity configuration:

runtime.conversion.handler = none
space.gobbling = bc
directive.if.emptycheck = false

But forgot this...

and check the Dependency changes below.

  • commons-collections and commons-logging aren't needed any more at runtime.
  • there's a new runtime dependency, slf4j-api 1.7.25.
  • you'll need an SLF4J binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vulnerability Security vulnerability which needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a vulnerability in Apache Velocity Engine 1.5,upgrade recommended
3 participants