Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised allocateID and generateID function #6621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xinluz6
Copy link
Contributor

@xinluz6 xinluz6 commented May 21, 2024

Fixes #6471

Changes proposed in this pull request:

  • This pull request updates the allocateID() and generateID() method to use higher-order random numbers

  • By shifting the current timestamp 20 bits left, it adds a random number up to 1 million (2^20) to the lower bits.

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels May 21, 2024
@wetneb
Copy link
Sponsor Member

wetneb commented Jun 4, 2024

Hi @xinluz6, apologies that we haven't reviewed this yet. To me it's not clear that the change proposed in #6471 is really a good move, so I have voiced that there.

In general, for your first PR it's worth going for an issue which states a problem / feature request that is already agreed on: you can do that by avoiding the issues labeled with "Status: Pending Review".

@xinluz6
Copy link
Contributor Author

xinluz6 commented Jun 7, 2024

Hi, thank you for your comment, I appreciate your guidance and will take it into consideration for future contributions. Thanks again for your review.

@tfmorris tfmorris removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate deterministic project IDs correlated with creation date
4 participants