Fix #1948: enc_message may be used uninitialized in p11test_case_ps…
#1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_oaep.c #1948 p11test_case_pss_oaep.c: In function 'pss_oaep_test': p11test_case_pss_oaep.c:424:2: error: 'enc_message' may be used uninitialized in this function [-Werror=maybe-uninitialized] 424 | free(enc_message); | ^ This is warning but it is treated as error.
Jakuje
reviewed
Feb 25, 2020
| @@ -376,7 +376,7 @@ int oaep_encrypt_decrypt_test(test_cert_t *o, token_info_t *info, test_mech_t *m | |||
| CK_BYTE *dec_message = NULL; | |||
| int dec_message_length = 0; | |||
| int message_length = 16; | |||
| unsigned char *enc_message; | |||
| unsigned char *enc_message = 0; | |||
There was a problem hiding this comment.
Please, use NULL here as it is pointer, not integer.
|
Confirmed. That solved that warning. |
frankmorgner
requested changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s_oaep.c
#1948
p11test_case_pss_oaep.c: In function 'pss_oaep_test':
p11test_case_pss_oaep.c:424:2: error: 'enc_message' may be used uninitialized in this function [-Werror=maybe-uninitialized]
424 | free(enc_message);
| ^
This is warning but it is treated as error.
Checklist