After a fork do not release resources shared with parent #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2015 16:46
- is initialized in sc_context_create with parm->flags - removes members paranoid_memory and enable_default_driver
|
@nmav what do you think? |
|
I haven't checked yet. I just returned from holidays. I'll try to find out some time and check it. |
|
That patch looks simpler and cleaner than 493. As of memory leaks, they remain, but as I said in 493 they should be treated as a separate issue. Bottom line, please apply that fix. |
|
@nmav thanks for the feedback. Could you open a separate issue with the missing memory leaks? thank you! |
frankmorgner
pushed a commit
that referenced
this pull request
Aug 4, 2015
After a fork do not release resources shared with parent
|
On second view, this patch doesn't handle the case where after a fork, C_Finalize() is called (without C_Initialize()). If that happens the same error will occur. I'll open an issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the second option proposed in #493 (comment) . I hope my approach is a bit cleaner and more complete than what is proposed in #493. Everything works as expected with a CardOS card and
pkcs11-tool --test-fork --login --test