libopensc: 'init', 'format', 'compare', 'is-valid' OID procedures #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a reason of number of bugs(*) that concern the OID management, the general usage OID procedures 'init', 'format', 'compare', 'is-valid' are introduced. These procedures should be used by all actors: libopensc, pkcs15, pkcs11, tools, .... (*) This bug reported by Andreas Schwier : OpenSC@8e75d97#commitcomment-1792477 In pkcs15-algo sc_asn1_get_algorithm_info() can return the OID without ending '-1' values: https://github.com/OpenSC/OpenSC/blob/staging/src/libopensc/pkcs15-algo.c#L452 https://github.com/OpenSC/OpenSC/blob/staging/src/libopensc/pkcs15-algo.c#L459
|
applied in 58b4304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a reason of number of bugs(*) that concern the OID management, the general usage OID procedures 'init', 'format', 'compare', 'is-valid' are introduced.
These procedures are to be used by all actors: libopensc, pkcs15, pkcs11, tools, ....
(*)
This bug reported by Andreas Schwier :
8e75d97#commitcomment-1792477
In pkcs15-algo sc_asn1_get_algorithm_info() can return the OID not full length and without ending '-1' value:
https://github.com/OpenSC/OpenSC/blob/staging/src/libopensc/pkcs15-algo.c#L452
https://github.com/OpenSC/OpenSC/blob/staging/src/libopensc/pkcs15-algo.c#L459